You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "sunil9977 (via GitHub)" <gi...@apache.org> on 2026/03/11 03:56:56 UTC

Re: [PR] CASSANDRA-18492: Allow value/element indexing on frozen collections in SAI [cassandra]

sunil9977 commented on code in PR #4561:
URL: https://github.com/apache/cassandra/pull/4561#discussion_r2915715804


##########
test/unit/org/apache/cassandra/index/sai/cql/CollectionIndexingTest.java:
##########
@@ -204,6 +222,941 @@ public void unindexedContainsExpressions()
         assertRows(execute("SELECT k, v, m FROM %s WHERE v = 1 AND m CONTAINS KEY 2 AND m CONTAINS 3"), row);
     }
 
+    @Test
+    public void testFrozenListFullIndex() throws Throwable
+    {
+        createTable("CREATE TABLE %s (pk int PRIMARY KEY, frozen_list frozen<list<int>>)");
+        createIndex("CREATE INDEX ON %s(FULL(frozen_list)) USING 'sai'");
+
+        execute("INSERT INTO %s (pk, frozen_list) VALUES (1, [1, 2, 3])");
+        execute("INSERT INTO %s (pk, frozen_list) VALUES (2, [1, 2, 3])");
+        execute("INSERT INTO %s (pk, frozen_list) VALUES (3, [4, 5, 6])");
+
+        beforeAndAfterFlush(() -> {
+            ResultSet rows = executeNet("SELECT pk FROM %s WHERE frozen_list = ?", Arrays.asList(1, 2, 3));
+            assertEquals(2, rows.all().size());
+        });
+    }
+
+    @Test
+    public void testFrozenListValuesIndex() throws Throwable
+    {
+        createTable("CREATE TABLE %s (pk int PRIMARY KEY, frozen_list frozen<list<int>>)");
+        createIndex("CREATE INDEX ON %s(VALUES(frozen_list)) USING 'sai'");
+
+        execute("INSERT INTO %s (pk, frozen_list) VALUES (1, [1, 2, 3])");
+        execute("INSERT INTO %s (pk, frozen_list) VALUES (2, [3, 4, 5])");
+        execute("INSERT INTO %s (pk, frozen_list) VALUES (3, [4, 5, 6])");
+
+        beforeAndAfterFlush(() -> {
+            ResultSet rows = executeNet("SELECT pk FROM %s WHERE frozen_list CONTAINS 3");
+            assertEquals(2, rows.all().size());
+        });
+    }
+
+    @Test
+    public void testFrozenSetFullIndex() throws Throwable
+    {
+        createTable("CREATE TABLE %s (pk int PRIMARY KEY, frozen_set frozen<set<text>>)");
+        createIndex("CREATE INDEX ON %s(FULL(frozen_set)) USING 'sai'");
+
+        execute("INSERT INTO %s (pk, frozen_set) VALUES (1, {'apple', 'banana'})");
+        execute("INSERT INTO %s (pk, frozen_set) VALUES (2, {'apple', 'banana'})");
+        execute("INSERT INTO %s (pk, frozen_set) VALUES (3, {'cherry', 'date'})");
+
+        beforeAndAfterFlush(() -> {
+            ResultSet rows = executeNet("SELECT pk FROM %s WHERE frozen_set = ?", Arrays.asList("apple", "banana"));
+            assertEquals(2, rows.all().size());
+        });
+    }
+
+    @Test
+    public void testFrozenSetValuesIndex() throws Throwable
+    {
+        createTable("CREATE TABLE %s (pk int PRIMARY KEY, frozen_set frozen<set<text>>)");
+        createIndex("CREATE INDEX ON %s(VALUES(frozen_set)) USING 'sai'");
+
+        execute("INSERT INTO %s (pk, frozen_set) VALUES (1, {'apple', 'banana'})");
+        execute("INSERT INTO %s (pk, frozen_set) VALUES (2, {'banana', 'cherry'})");
+        execute("INSERT INTO %s (pk, frozen_set) VALUES (3, {'cherry', 'date'})");
+
+        beforeAndAfterFlush(() -> {
+            ResultSet rows = executeNet("SELECT pk FROM %s WHERE frozen_set CONTAINS 'banana'");
+            assertEquals(2, rows.all().size());
+        });
+    }
+
+    @Test
+    public void testFrozenMapFullIndexEquality() throws Throwable
+    {
+        createTable("CREATE TABLE %s (pk int PRIMARY KEY, frozen_map frozen<map<text, text>>)");
+        createIndex("CREATE INDEX ON %s(FULL(frozen_map)) USING 'sai'");
+
+        execute("INSERT INTO %s (pk, frozen_map) VALUES (1, {'k1': 'v1', 'k2': 'v2'})");
+        execute("INSERT INTO %s (pk, frozen_map) VALUES (2, {'k1': 'v1', 'k2': 'v2'})");
+        execute("INSERT INTO %s (pk, frozen_map) VALUES (3, {'k3': 'v3', 'k4': 'v4'})");
+
+        beforeAndAfterFlush(() -> {
+            ResultSet rows = executeNet("SELECT pk FROM %s WHERE frozen_map = ?", ImmutableMap.of("k1", "v1", "k2", "v2"));
+            assertEquals(2, rows.all().size());
+        });
+    }
+
+    @Test
+    public void testFrozenMapFullIndexMapEntryRequiresFiltering() throws Throwable
+    {
+        createTable("CREATE TABLE %s (pk int PRIMARY KEY, frozen_map frozen<map<int, text>>)");
+        createIndex("CREATE INDEX ON %s(FULL(frozen_map)) USING 'sai'");
+
+        execute("INSERT INTO %s (pk, frozen_map) VALUES (1, ?)", ImmutableMap.of(1, "v1", 2, "v2"));
+        execute("INSERT INTO %s (pk, frozen_map) VALUES (2, ?)", ImmutableMap.of(1, "v1", 3, "v3"));
+        execute("INSERT INTO %s (pk, frozen_map) VALUES (3, ?)", ImmutableMap.of(3, "v3", 4, "v4"));
+
+        beforeAndAfterFlush(() -> {
+            assertInvalidMessage(StatementRestrictions.REQUIRES_ALLOW_FILTERING_MESSAGE,
+                                 "SELECT pk FROM %s WHERE frozen_map[1] = 'v1'");
+
+            ResultSet rows = executeNet("SELECT pk FROM %s WHERE frozen_map[1] = 'v1' ALLOW FILTERING");
+            assertEquals(2, rows.all().size());
+        });
+    }
+
+    @Test
+    public void testFrozenMapEntriesIndexMapEntry() throws Throwable

Review Comment:
   Thanks @adelapena  for pointing out. I've addressed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org