You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by agneya2001 <gi...@git.apache.org> on 2016/01/05 06:22:30 UTC

[GitHub] cloudstack pull request: 4.7 quota test

GitHub user agneya2001 opened a pull request:

    https://github.com/apache/cloudstack/pull/1306

    4.7 quota test

    engine/schema: Use semantically correct upgrade path 4.6.2->4.7.0 
    QuotaStatementTest: fix the method invocation verification

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shapeblue/cloudstack 4.7-quota-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1306
    
----
commit 6c5a182c39d62c7615ba3c9ebdecc7fffc541d9f
Author: Rohit Yadav <ro...@shapeblue.com>
Date:   2015-12-16T09:01:00Z

    engine/schema: Use semantically correct upgrade path 4.6.2->4.7.0
    
    Adds an explicit upgrade path class from 4.6.2 to 4.7.0, that extends over
    the upgrade path from 4.6.1 to 4.7.0
    
    Signed-off-by: Rohit Yadav <ro...@shapeblue.com>

commit 89f9180e7a8e35541f0fe807d28e7b03b39dedf0
Author: Abhinandan Prateek <ab...@shapeblue.com>
Date:   2016-01-04T10:58:42Z

    QuotaStatementTest: fix the method invocation verification

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.7 quota test

Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:

    https://github.com/apache/cloudstack/pull/1306#issuecomment-168987361
  
    More tests is always better! LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.7 quota test

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1306#issuecomment-169015725
  
    This seems to fix the broken unit test. LGTM.
    
    ```
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 11:35.450s
    [INFO] Finished at: Tue Jan 05 14:15:27 GMT 2016
    [INFO] Final Memory: 102M/471M
    [INFO] ------------------------------------------------------------------------
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: 4.7 quota test

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cloudstack/pull/1306


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---