[GitHub] [arrow-datafusion] alamb commented on a change in pull request #845: Fix right, full join handling when having multiple non-matching rows at the left side

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #845:
URL: https://github.com/apache/arrow-datafusion/pull/845#discussion_r685341006



##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -745,9 +747,12 @@ fn build_join_indexes(
                                 &keys_values,
                             )? {
                                 left_indices.append_value(i)?;
-                            } else {
-                                left_indices.append_null()?;
+                                right_indices.append_value(row as u32)?;
+                                no_match = false;
                             }
+                        }
+                        if no_match {

Review comment:
       ```suggestion
                          // If no rows matched left, still must keep the right
                          // with all nulls for left
                           if no_match {
   ```
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org