You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2025/03/04 12:25:10 UTC

[PR] AIP-84 | Fix Merged Permission for Variables and Pools [airflow]

jason810496 opened a new pull request, #47345:
URL: https://github.com/apache/airflow/pull/47345

   
   related: #42360 
   
   ## What
   
   Fix #47194, #47129
   
   - `airflow/api_fastapi/core_api/security.py`
       - Fix typo in `requires_access_connection` function ( should call `is_authorized_connection` instead of `is_authorized_pool` )
       - Use `lamda` instead of adding new callback definition in each `requires_access_<entity>`
       - Add type hint for `requires_access_<entity>` ( except for `requires_access_dag`, the #47062 PR will add type hint for the dag one )
   - `tests/api_fastapi/conftest.py`
       - Retrieve auth_manger from `app.state` instead of creating a new one
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] AIP-84 | Fix Merged Permission for Connections and Pools [airflow]

Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on PR #47345:
URL: https://github.com/apache/airflow/pull/47345#issuecomment-2697485189

   > Thanks
   All CI are green 🎉


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] AIP-84 | Fix Merged Permission for Connections and Pools [airflow]

Posted by "rawwar (via GitHub)" <gi...@apache.org>.
rawwar commented on PR #47345:
URL: https://github.com/apache/airflow/pull/47345#issuecomment-2700166603

   @jason810496 , Thank you! 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] AIP-84 | Fix Merged Permission for Variables and Pools [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #47345:
URL: https://github.com/apache/airflow/pull/47345#issuecomment-2697470022

   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] AIP-84 | Fix Merged Permission for Connections and Pools [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #47345:
URL: https://github.com/apache/airflow/pull/47345


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org