[jira] [Commented] (FLINK-10711) flink-end-to-end-tests can fail silently

["Dawid Wysakowicz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671824#comment-16671824 ] 

Dawid Wysakowicz commented on FLINK-10711:
------------------------------------------

I am afraid it is not always as easy as setting those flags in every single bash script. Sometimes commands can fail, but subsequent commands use this value to validate that outcome/state of the test. To give you an example to check if container is running I've used command {{docker inspect -f '{{.State.Running}}' master}} which ends with an error if there is no container called master, but this is checked in subsequent commands. With the {{set -e}} this test would end up immediately. 

My point here is that, if we want to add this, we would have to analyze each script carefully how adding this flag would affect the script.

> flink-end-to-end-tests can fail silently
> ----------------------------------------
>
>                 Key: FLINK-10711
>                 URL: https://issues.apache.org/jira/browse/FLINK-10711
>             Project: Flink
>          Issue Type: Bug
>          Components: E2E Tests
>    Affects Versions: 1.7.0
>            Reporter: Piotr Nowojski
>            Assignee: Hequn Cheng
>            Priority: Blocker
>             Fix For: 1.7.0
>
>
> Because they are written in bash and they are not setting
> {code:bash}
> set -e
> {code}
> at the beginning, errors can be swallowed silently.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)