You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/08/02 15:17:06 UTC

[GitHub] [incubator-shenyu] Banana1995 opened a new pull request #1856: add some unit test for enum

Banana1995 opened a new pull request #1856:
URL: https://github.com/apache/incubator-shenyu/pull/1856


   // Describe your PR here; eg. Fixes #issueNo
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor/).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1856: add some unit test for enum

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1856:
URL: https://github.com/apache/incubator-shenyu/pull/1856#issuecomment-891882936


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1856](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4796126) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/4747666168b28d14c750f3850b272d5ed8c5bc8e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4747666) will **increase** coverage by `5.77%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1856      +/-   ##
   ============================================
   + Coverage     62.43%   68.21%   +5.77%     
   - Complexity     2465     2665     +200     
   ============================================
     Files           488      489       +1     
     Lines         10774    10973     +199     
     Branches       1076     1076              
   ============================================
   + Hits           6727     7485     +758     
   + Misses         3520     2927     -593     
   - Partials        527      561      +34     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/shenyu/admin/transfer/ConditionTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvQ29uZGl0aW9uVHJhbnNmZXIuamF2YQ==) | `53.65% <0.00%> (-46.35%)` | :arrow_down: |
   | [.../apache/shenyu/admin/transfer/AppAuthTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvQXBwQXV0aFRyYW5zZmVyLmphdmE=) | `68.88% <0.00%> (-31.12%)` | :arrow_down: |
   | [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `32.43% <0.00%> (-25.68%)` | :arrow_down: |
   | [...org/apache/shenyu/admin/utils/ThreadLocalUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlsLmphdmE=) | `66.66% <0.00%> (-22.23%)` | :arrow_down: |
   | [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `78.84% <0.00%> (-21.16%)` | :arrow_down: |
   | [...g/apache/shenyu/admin/transfer/PluginTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvUGx1Z2luVHJhbnNmZXIuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `57.14% <0.00%> (-2.05%)` | :arrow_down: |
   | [...gin/apache/dubbo/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vY2FjaGUvQXBwbGljYXRpb25Db25maWdDYWNoZS5qYXZh) | `74.39% <0.00%> (-0.33%)` | :arrow_down: |
   | [...in/alibaba/dubbo/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFsaWJhYmEtZHViYm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYWxpYmFiYS9kdWJiby9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `80.24% <0.00%> (-0.22%)` | :arrow_down: |
   | [...va/org/apache/shenyu/web/filter/TimeWebFilter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9maWx0ZXIvVGltZVdlYkZpbHRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [45 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4747666...4796126](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] Banana1995 commented on pull request #1856: add some unit test for enum

Posted by GitBox <gi...@apache.org>.
Banana1995 commented on pull request #1856:
URL: https://github.com/apache/incubator-shenyu/pull/1856#issuecomment-891892620


   #1827


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #1856: add some unit test for enum

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1856:
URL: https://github.com/apache/incubator-shenyu/pull/1856#issuecomment-891882936


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1856](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4796126) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/4747666168b28d14c750f3850b272d5ed8c5bc8e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4747666) will **increase** coverage by `5.44%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1856      +/-   ##
   ============================================
   + Coverage     62.43%   67.88%   +5.44%     
   - Complexity     2465     2652     +187     
   ============================================
     Files           488      489       +1     
     Lines         10774    10973     +199     
     Branches       1076     1076              
   ============================================
   + Hits           6727     7449     +722     
   + Misses         3520     2962     -558     
   - Partials        527      562      +35     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/shenyu/admin/transfer/ConditionTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvQ29uZGl0aW9uVHJhbnNmZXIuamF2YQ==) | `53.65% <0.00%> (-46.35%)` | :arrow_down: |
   | [.../apache/shenyu/admin/transfer/AppAuthTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvQXBwQXV0aFRyYW5zZmVyLmphdmE=) | `68.88% <0.00%> (-31.12%)` | :arrow_down: |
   | [...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jYWNoZS9HcnBjQ2xpZW50Q2FjaGUuamF2YQ==) | `66.66% <0.00%> (-27.78%)` | :arrow_down: |
   | [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `32.43% <0.00%> (-25.68%)` | :arrow_down: |
   | [...org/apache/shenyu/admin/utils/ThreadLocalUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlsLmphdmE=) | `66.66% <0.00%> (-22.23%)` | :arrow_down: |
   | [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `78.84% <0.00%> (-21.16%)` | :arrow_down: |
   | [...g/apache/shenyu/admin/transfer/PluginTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvUGx1Z2luVHJhbnNmZXIuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `56.84% <0.00%> (-6.32%)` | :arrow_down: |
   | [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `71.84% <0.00%> (-2.92%)` | :arrow_down: |
   | [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `57.14% <0.00%> (-2.05%)` | :arrow_down: |
   | ... and [46 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4747666...4796126](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] yu199195 merged pull request #1856: add some unit test for enum

Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #1856:
URL: https://github.com/apache/incubator-shenyu/pull/1856


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1856: add some unit test for enum

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1856:
URL: https://github.com/apache/incubator-shenyu/pull/1856#issuecomment-891882936


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1856](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4796126) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/4747666168b28d14c750f3850b272d5ed8c5bc8e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4747666) will **increase** coverage by `5.96%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1856      +/-   ##
   ============================================
   + Coverage     62.43%   68.40%   +5.96%     
   - Complexity     2465     2670     +205     
   ============================================
     Files           488      489       +1     
     Lines         10774    10973     +199     
     Branches       1076     1076              
   ============================================
   + Hits           6727     7506     +779     
   + Misses         3520     2906     -614     
   - Partials        527      561      +34     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/shenyu/admin/transfer/ConditionTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvQ29uZGl0aW9uVHJhbnNmZXIuamF2YQ==) | `53.65% <0.00%> (-46.35%)` | :arrow_down: |
   | [.../apache/shenyu/admin/transfer/AppAuthTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvQXBwQXV0aFRyYW5zZmVyLmphdmE=) | `68.88% <0.00%> (-31.12%)` | :arrow_down: |
   | [...org/apache/shenyu/admin/utils/ThreadLocalUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlsLmphdmE=) | `66.66% <0.00%> (-22.23%)` | :arrow_down: |
   | [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `78.84% <0.00%> (-21.16%)` | :arrow_down: |
   | [...g/apache/shenyu/admin/transfer/PluginTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvUGx1Z2luVHJhbnNmZXIuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [...gin/apache/dubbo/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFwYWNoZS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9hcGFjaGUvZHViYm8vY2FjaGUvQXBwbGljYXRpb25Db25maWdDYWNoZS5qYXZh) | `74.39% <0.00%> (-0.33%)` | :arrow_down: |
   | [...in/alibaba/dubbo/cache/ApplicationConfigCache.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWFsaWJhYmEtZHViYm8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYWxpYmFiYS9kdWJiby9jYWNoZS9BcHBsaWNhdGlvbkNvbmZpZ0NhY2hlLmphdmE=) | `80.24% <0.00%> (-0.22%)` | :arrow_down: |
   | [...va/org/apache/shenyu/web/filter/TimeWebFilter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9maWx0ZXIvVGltZVdlYkZpbHRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...apache/shenyu/admin/transfer/SelectorTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvU2VsZWN0b3JUcmFuc2Zlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...enyu/common/enums/AdminDataPermissionTypeEnum.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi9lbnVtcy9BZG1pbkRhdGFQZXJtaXNzaW9uVHlwZUVudW0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [44 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1856/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4747666...4796126](https://codecov.io/gh/apache/incubator-shenyu/pull/1856?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org