You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@polaris.apache.org by "MonkeyCanCode (via GitHub)" <gi...@apache.org> on 2025/11/19 06:40:59 UTC

[PR] feat: Make generate_clients.py windows compatible [polaris]

MonkeyCanCode opened a new pull request, #3084:
URL: https://github.com/apache/polaris/pull/3084

   <!--
   📝 Describe what changes you're proposing, especially breaking or user-facing changes. 
   📖 See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
   -->
   
   This PR is to added windows support for python cli (https://github.com/apache/polaris/issues/3051). 
   
   Here are some sample output:
   
   Poetry install:
   ```
   (venv) PS C:\Users\Yong\Desktop\test\polaris-main\polaris-main\client\python> poetry install --all-extras
   Installing dependencies from lock file
   
   No dependencies to install or update
   
   Installing the current project: apache-polaris (1.2.0)Preparing build environment with build-system requirements poetry-core==2.2.1, openapi-generator-cli==7.12.0
   Preparing spec directory...
   Copying spec directory from C:\Users\Yong\Desktop\test\polaris-main\polaris-main\spec to C:\Users\Yong\Desktop\test\polaris-main\polaris-main\client\python\spec
   Spec directory copied to ensure it is up-to-date.
   Deleting old tests...
   Old test deletion complete.
   Fixing catalog models __init__.py...
   Catalog models __init__.py fixed.
   Re-applying license headers...
   License fix complete.
   Installing the current project: apache-polaris (1.2.0)
   
   (venv) PS C:\Users\Yong\Desktop\test\polaris-main\polaris-main\client\python> polaris
   ...
   Exception: Please provide credentials via either --client-id & --client-secret or --access-token. Alternatively, you may set the environment variables CLIENT_ID & CLIENT_SECRET.
   ```
   
   Poetry build:
   ```
   (venv) PS C:\Users\Yong\Desktop\test\polaris-main\polaris-main\client\python> poetry build
   Building apache-polaris (1.2.0)
   Building sdist
   Building wheel
   (venv) PS C:\Users\Yong\Desktop\test\polaris-main\polaris-main\client\python\dist> ls
   
   
       Directory: C:\Users\Yong\Desktop\test\polaris-main\polaris-main\client\python\dist
   
   
   Mode                 LastWriteTime         Length Name
   ----                 -------------         ------ ----
   -a----        11/19/2025  12:26 AM         548278 apache_polaris-1.2.0-cp310-cp310-win_amd64.whl
   -a----        11/19/2025  12:26 AM         233088 apache_polaris-1.2.0.tar.gz
   ```
   
   Install whl from poetry build:
   ```
   (venv) PS C:\Users\Yong\Desktop\test\test_pkg> pip install C:\Users\Yong\Desktop\test\polaris-main\polaris-main\client\python\dist\apache_polaris-1.2.0-cp310-cp310-win_amd64.whl
   Processing c:\users\Yong\desktop\test\polaris-main\polaris-main\client\python\dist\apache_polaris-1.2.0-cp310-cp310-win_amd64.whl
   ...
   Installing collected packages: six, urllib3, python-dateutil, jmespath, typing-extensions, botocore, typing-inspection, s3transfer, pydantic-core, annotated-types, pydantic, boto3, apache-polaris
   Successfully installed annotated-types-0.7.0 apache-polaris-1.2.0 boto3-1.40.76 botocore-1.40.76 jmespath-1.0.1 pydantic-2.11.10 pydantic-core-2.33.2 python-dateutil-2.9.0.post0 s3transfer-0.14.0 six-1.17.0 typing-extensions-4.15.0 typing-inspection-0.4.2 urllib3-2.5.0
   ...
   (venv) PS C:\Users\Yong\Desktop\test\test_pkg> polaris
   ...
   Exception: Please provide credentials via either --client-id & --client-secret or --access-token. Alternatively, you may set the environment variables CLIENT_ID & CLIENT_SECRET.
   ```
   
   Install sdist from poetry build:
   ```
   (venv) PS C:\Users\Yong\Desktop\test\test_dist> pip install C:\Users\Yong\Desktop\test\polaris-main\polaris-main\client\python\dist\apache_polaris-1.2.0.tar.gz
   Processing c:\users\Yong\desktop\test\polaris-main\polaris-main\client\python\dist\apache_polaris-1.2.0.tar.gz
   ...
   Successfully built apache-polaris
   Installing collected packages: six, urllib3, python-dateutil, jmespath, typing-extensions, botocore, typing-inspection, s3transfer, pydantic-core, annotated-types, pydantic, boto3, apache-polaris
   Successfully installed annotated-types-0.7.0 apache-polaris-1.2.0 boto3-1.40.76 botocore-1.40.76 jmespath-1.0.1 pydantic-2.11.10 pydantic-core-2.33.2 python-dateutil-2.9.0.post0 s3transfer-0.14.0 six-1.17.0 typing-extensions-4.15.0 typing-inspection-0.4.2 urllib3-2.5.0
   ...
   (venv) PS C:\Users\Yong\Desktop\test\test_dist> polaris
   ...
   Exception: Please provide credentials via either --client-id & --client-secret or --access-token. Alternatively, you may set the environment variables CLIENT_ID & CLIENT_SECRET.
   ```
   
   ## Checklist
   - [x] 🛡️ Don't disclose security issues! (contact security@apache.org)
   - [x] 🔗 Clearly explained why the changes are needed, or linked related issues: Fixes #
   - [x] 🧪 Added/updated tests with good coverage, or manually tested (and explained how)
   - [x] 💡 Added comments for complex logic
   - [x] 🧾 Updated `CHANGELOG.md` (if needed)
   - [x] 📚 Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Make generate_clients.py windows compatible [polaris]

Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.

MonkeyCanCode commented on PR #3084:
URL: https://github.com/apache/polaris/pull/3084#issuecomment-3552831243

   That is correct. I think the ask is for ensure on windows, people can do pip install and be able to integrate with Polaris with CLI.
   
   > I don't mind making the Python part buildable on Win at all, which might be a requirement for cmake and/or testing against Win?
   > "Polaris itself" however can only be built on Linux or macOS.
   > 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Make generate_clients.py windows compatible [polaris]

Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.

MonkeyCanCode merged PR #3084:
URL: https://github.com/apache/polaris/pull/3084


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Make generate_clients.py windows compatible [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.

snazy commented on PR #3084:
URL: https://github.com/apache/polaris/pull/3084#issuecomment-3551603071

   I don't mind making the Python part buildable on Win at all, which might be a requirement for cmake and/or testing against Win?
   "Polaris itself" however can only be built on Linux or macOS.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Make generate_clients.py windows compatible [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.

snazy commented on PR #3084:
URL: https://github.com/apache/polaris/pull/3084#issuecomment-3557070523

   Nah, no concerns from my side. It was just a question and note.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: Make generate_clients.py windows compatible [polaris]

Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.

MonkeyCanCode commented on PR #3084:
URL: https://github.com/apache/polaris/pull/3084#issuecomment-3555768171

   @snazy any concerns before this merge? I think we are all on the same page.
   
   > This is great! Thanks for the quick fix here.
   > 
   > Yes, the goal here is just to ensure windows user can install Polaris CLI. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org