You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/11 01:36:47 UTC
[GitHub] [skywalking] codecov-io edited a comment on issue #4337: Set up
more strict code styles and fix existing issues
codecov-io edited a comment on issue #4337: Set up more strict code styles and fix existing issues
URL: https://github.com/apache/skywalking/pull/4337#issuecomment-583853097
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=h1) Report
> Merging [#4337](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/8c96fd49ddecb90bb8c98674b378c0d24483c5a7?src=pr&el=desc) will **decrease** coverage by `0.6%`.
> The diff coverage is `34.54%`.
[](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4337 +/- ##
==========================================
- Coverage 27.05% 26.45% -0.61%
==========================================
Files 1176 1176
Lines 25718 26586 +868
Branches 3675 3667 -8
==========================================
+ Hits 6959 7033 +74
- Misses 18139 18941 +802
+ Partials 620 612 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...he/skywalking/apm/agent/core/os/ProcessorUtil.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvUHJvY2Vzc29yVXRpbC5qYXZh) | `100% <ø> (ø)` | :arrow_up: |
| [...m/toolkit/log/log4j/v1/x/TraceIdPatternLayout.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbG9nNGotMS54L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L2xvZy9sb2c0ai92MS94L1RyYWNlSWRQYXR0ZXJuTGF5b3V0LmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...he/skywalking/apm/agent/core/plugin/PluginCfg.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpbkNmZy5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...ing/apm/agent/core/logging/core/WriterFactory.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL1dyaXRlckZhY3RvcnkuamF2YQ==) | `69.23% <ø> (ø)` | :arrow_up: |
| [.../core/logging/core/coverts/AgentNameConverter.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvdmVydHMvQWdlbnROYW1lQ29udmVydGVyLmphdmE=) | `100% <ø> (ø)` | :arrow_up: |
| [...ing/apm/agent/core/plugin/DynamicPluginLoader.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0R5bmFtaWNQbHVnaW5Mb2FkZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...e/skywalking/apm/agent/core/jvm/gc/G1GCModule.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL0cxR0NNb2R1bGUuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...agent/core/plugin/match/MethodAnnotationMatch.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL01ldGhvZEFubm90YXRpb25NYXRjaC5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...apm/agent/core/plugin/PluginResourcesResolver.java](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL1BsdWdpblJlc291cmNlc1Jlc29sdmVyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| ... and [1120 more](https://codecov.io/gh/apache/skywalking/pull/4337/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=footer). Last update [8c96fd4...bd67f14](https://codecov.io/gh/apache/skywalking/pull/4337?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services