You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/01 12:15:19 UTC
[GitHub] [rocketmq] cserwen opened a new pull request #3570: [ISSUE #3491] Wake up the waiting pop-request in time
cserwen opened a new pull request #3570:
URL: https://github.com/apache/rocketmq/pull/3570
**Make sure set the target branch to `develop`**
## What is the purpose of the change
#3491
## Brief changelog
Wake up the request when scan `pollingMap`
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] martinezmatias commented on pull request #3570: [ISSUE #3491] Wake up the waiting pop-request in time
Posted by GitBox <gi...@apache.org>.
martinezmatias commented on pull request #3570:
URL: https://github.com/apache/rocketmq/pull/3570#issuecomment-989874217
Hi, we are researchers in software engineering, working on a novel GitHub bot for helping understand build failures.
We have run our prototype bot [flacocobot](https://github.com/SpoonLabs/flacoco) on this failing PR and below are the results.
What do you think?
Thanks a lot! --Davide (@dginelli), André (@andre15silva), Matias (@martinezmatias), Benjamin (@danglotb), Martin (@monperrus)
**********************************
The line (32) of the file org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueAveragely has been identified with a suspiciousness value of 56.20%.
<details>
<summary>Failing tests that cover this line</summary>
- `org.apache.rocketmq.client.consumer.rebalance.AllocateMachineRoomNearByTest#testRun10RandomCase`
- `org.apache.rocketmq.client.impl.consumer.ConsumeMessageOrderlyServiceTest#testConsumeMessageDirectly_WithException`
- `org.apache.rocketmq.client.impl.consumer.ConsumeMessageOrderlyServiceTest#testConsumeMessageDirectly_WithNoException`
- `org.apache.rocketmq.client.consumer.rebalance.AllocateMachineRoomNearByTest#test1`
- `org.apache.rocketmq.client.consumer.rebalance.AllocateMachineRoomNearByTest#test3`
- `org.apache.rocketmq.client.consumer.rebalance.AllocateMachineRoomNearByTest#test2`
</details>
**********************************
The line (47) of the file org/apache/rocketmq/client/consumer/rebalance/AllocateMessageQueueConsistentHash has been identified with a suspiciousness value of 45.88%.
<details>
<summary>Failing tests that cover this line</summary>
- `org.apache.rocketmq.client.consumer.rebalance.AllocateMessageQueueConsitentHashTest#testRun100RandomCase`
- `org.apache.rocketmq.client.consumer.rebalance.AllocateMessageQueueConsitentHashTest#testAllocate1`
- `org.apache.rocketmq.client.consumer.rebalance.AllocateMessageQueueConsitentHashTest#testAllocate2`
- `org.apache.rocketmq.client.consumer.rebalance.AllocateMessageQueueConsitentHashTest#testMessageQueueIllegalArgument`
</details>
**********************************
The line (106) of the file org/apache/rocketmq/client/Validators has been identified with a suspiciousness value of 45.88%.
<details>
<summary>Failing tests that cover this line</summary>
- `org.apache.rocketmq.client.ValidatorsTest#testCheckTopic_HasIllegalCharacters`
- `org.apache.rocketmq.client.ValidatorsTest#testCheckTopic_BlankTopic`
- `org.apache.rocketmq.client.ValidatorsTest#testCheckTopic_Success`
- `org.apache.rocketmq.client.ValidatorsTest#testCheckTopic_TooLongTopic`
</details>
**********************************
The line (41) of the file org/apache/rocketmq/client/impl/consumer/ProcessQueue has been identified with a suspiciousness value of 39.74%.
<details>
<summary>Failing tests that cover this line</summary>
- `org.apache.rocketmq.client.impl.consumer.ProcessQueueTest#testFillProcessQueueInfo`
- `org.apache.rocketmq.client.impl.consumer.ProcessQueueTest#testCachedMessageSize`
- `org.apache.rocketmq.client.impl.consumer.ProcessQueueTest#testCachedMessageCount`
</details>
**********************************
The line (24) of the file org/apache/rocketmq/client/producer/selector/SelectMessageQueueByHash has been identified with a suspiciousness value of 22.94%.
<details>
<summary>Failing tests that cover this line</summary>
- `org.apache.rocketmq.client.producer.selector.SelectMessageQueueByHashTest#testSelect`
</details>
**********************************
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3570: [ISSUE #3491] Wake up the waiting pop-request in time
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3570:
URL: https://github.com/apache/rocketmq/pull/3570#issuecomment-1055159302
[](https://coveralls.io/builds/46963462)
Coverage decreased (-0.003%) to 52.611% when pulling **76e99c382617bf725ea149910acc22d69fac74ea on cserwen:wake_up** into **de76e06d6da8e8646d2ac59ea061e8dc2653aae8 on apache:5.0.0-alpha**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org