You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2019/02/23 07:13:38 UTC
Re: Review Request 69553: Changed the definition of `uid_t` and
`gid_t` to UNIT for Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69553/#review213111
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Dec. 11, 2018, 7:06 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69553/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2018, 7:06 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8813
> https://issues.apache.org/jira/browse/MESOS-8813
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is to be consistent with other platforms. And we also need this
> change for https://reviews.apache.org/r/69479/, otherwise that patch
> cannot be compiled on Windows because we do not have a matched `parse`
> function for `int` in 3rdparty/stout/include/stout/flags/parse.hpp.
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/stout/windows.hpp 075ad54ac694a11cb1e981a499e99c02cb734bc6
>
>
> Diff: https://reviews.apache.org/r/69553/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>