You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2024/02/28 02:58:08 UTC

Re: [PR] [SPARK-47202][PYTHON] Fix typo breaking datetimes with tzinfo [spark]

HyukjinKwon commented on code in PR #45301:
URL: https://github.com/apache/spark/pull/45301#discussion_r1505269608


##########
python/pyspark/sql/pandas/types.py:
##########
@@ -993,7 +993,7 @@ def convert_struct(value: Any) -> Any:
 
             def convert_timestamp(value: Any) -> Any:
                 if isinstance(value, datetime.datetime) and value.tzinfo is not None:
-                    ts = pd.Timstamp(value)
+                    ts = pd.Timestamp(value)

Review Comment:
   I am fine as is because it's pretty obvious but would be good to have a test at `python/pyspark/sql/tests/test_arrow.py`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org