You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by bo...@apache.org on 2012/09/30 22:34:33 UTC
git commit: Fixed TAP5-2004 ("Tapestry-Ioc fails to build on
Windows") with patch from Chris Poulsen
Updated Branches:
refs/heads/5.3 db4ff9b7d -> 35443aa07
Fixed TAP5-2004 ("Tapestry-Ioc fails to build on Windows")
with patch from Chris Poulsen
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/35443aa0
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/35443aa0
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/35443aa0
Branch: refs/heads/5.3
Commit: 35443aa0792c66e122cdd41b5fdd788dd6e77c41
Parents: db4ff9b
Author: bharner <bo...@apache.org>
Authored: Sun Sep 30 16:24:41 2012 -0400
Committer: bharner <bo...@apache.org>
Committed: Sun Sep 30 16:24:41 2012 -0400
----------------------------------------------------------------------
.../java/org/apache/tapestry5/ioc/ReloadTest.java | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/35443aa0/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
----------------------------------------------------------------------
diff --git a/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java b/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
index 4120f1f..e06e155 100644
--- a/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
+++ b/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
@@ -1,4 +1,4 @@
-// Copyright 2010 The Apache Software Foundation
+// Copyright 2012 The Apache Software Foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -68,7 +68,7 @@ public class ReloadTest extends IOCTestCase
// URLClassLoader REQUIRES that File URLs end with a slash! That's a half hour of my life gone!
- URL classesURL = new URL("file:" + classesDir.getCanonicalPath() + "/");
+ URL classesURL = new URL(classesDir.toURI().toString() + "/");
System.out.println("Reload classes dir: " + classesURL);
Re: git commit: Fixed TAP5-2004 ("Tapestry-Ioc fails to build on
Windows") with patch from Chris Poulsen
Posted by Bob Harner <bo...@gmail.com>.
Certainly will, just gotta resolve a local Git workspace problem I caused myself
On Tue, Oct 2, 2012 at 5:58 PM, Howard Lewis Ship <hl...@gmail.com> wrote:
> Could this patch be applied to master as well? Thanks!
>
> On Sun, Sep 30, 2012 at 1:34 PM, <bo...@apache.org> wrote:
>> Updated Branches:
>> refs/heads/5.3 db4ff9b7d -> 35443aa07
>>
>>
>> Fixed TAP5-2004 ("Tapestry-Ioc fails to build on Windows")
>> with patch from Chris Poulsen
>>
>> Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/35443aa0
>> Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/35443aa0
>> Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/35443aa0
>>
>> Branch: refs/heads/5.3
>> Commit: 35443aa0792c66e122cdd41b5fdd788dd6e77c41
>> Parents: db4ff9b
>> Author: bharner <bo...@apache.org>
>> Authored: Sun Sep 30 16:24:41 2012 -0400
>> Committer: bharner <bo...@apache.org>
>> Committed: Sun Sep 30 16:24:41 2012 -0400
>>
>> ----------------------------------------------------------------------
>> .../java/org/apache/tapestry5/ioc/ReloadTest.java | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/35443aa0/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
>> ----------------------------------------------------------------------
>> diff --git a/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java b/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
>> index 4120f1f..e06e155 100644
>> --- a/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
>> +++ b/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
>> @@ -1,4 +1,4 @@
>> -// Copyright 2010 The Apache Software Foundation
>> +// Copyright 2012 The Apache Software Foundation
>> //
>> // Licensed under the Apache License, Version 2.0 (the "License");
>> // you may not use this file except in compliance with the License.
>> @@ -68,7 +68,7 @@ public class ReloadTest extends IOCTestCase
>>
>> // URLClassLoader REQUIRES that File URLs end with a slash! That's a half hour of my life gone!
>>
>> - URL classesURL = new URL("file:" + classesDir.getCanonicalPath() + "/");
>> + URL classesURL = new URL(classesDir.toURI().toString() + "/");
>>
>> System.out.println("Reload classes dir: " + classesURL);
>>
>>
>
>
>
> --
> Howard M. Lewis Ship
>
> Creator of Apache Tapestry
>
> The source for Tapestry training, mentoring and support. Contact me to
> learn how I can get you up and productive in Tapestry fast!
>
> (971) 678-5210
> http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: git commit: Fixed TAP5-2004 ("Tapestry-Ioc fails to build on
Windows") with patch from Chris Poulsen
Posted by Howard Lewis Ship <hl...@gmail.com>.
Could this patch be applied to master as well? Thanks!
On Sun, Sep 30, 2012 at 1:34 PM, <bo...@apache.org> wrote:
> Updated Branches:
> refs/heads/5.3 db4ff9b7d -> 35443aa07
>
>
> Fixed TAP5-2004 ("Tapestry-Ioc fails to build on Windows")
> with patch from Chris Poulsen
>
> Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
> Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/35443aa0
> Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/35443aa0
> Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/35443aa0
>
> Branch: refs/heads/5.3
> Commit: 35443aa0792c66e122cdd41b5fdd788dd6e77c41
> Parents: db4ff9b
> Author: bharner <bo...@apache.org>
> Authored: Sun Sep 30 16:24:41 2012 -0400
> Committer: bharner <bo...@apache.org>
> Committed: Sun Sep 30 16:24:41 2012 -0400
>
> ----------------------------------------------------------------------
> .../java/org/apache/tapestry5/ioc/ReloadTest.java | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/35443aa0/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
> ----------------------------------------------------------------------
> diff --git a/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java b/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
> index 4120f1f..e06e155 100644
> --- a/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
> +++ b/tapestry-ioc/src/test/java/org/apache/tapestry5/ioc/ReloadTest.java
> @@ -1,4 +1,4 @@
> -// Copyright 2010 The Apache Software Foundation
> +// Copyright 2012 The Apache Software Foundation
> //
> // Licensed under the Apache License, Version 2.0 (the "License");
> // you may not use this file except in compliance with the License.
> @@ -68,7 +68,7 @@ public class ReloadTest extends IOCTestCase
>
> // URLClassLoader REQUIRES that File URLs end with a slash! That's a half hour of my life gone!
>
> - URL classesURL = new URL("file:" + classesDir.getCanonicalPath() + "/");
> + URL classesURL = new URL(classesDir.toURI().toString() + "/");
>
> System.out.println("Reload classes dir: " + classesURL);
>
>
--
Howard M. Lewis Ship
Creator of Apache Tapestry
The source for Tapestry training, mentoring and support. Contact me to
learn how I can get you up and productive in Tapestry fast!
(971) 678-5210
http://howardlewisship.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org