You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@syncope.apache.org by mteo <gi...@git.apache.org> on 2016/05/03 16:20:47 UTC
[GitHub] syncope pull request: [SYNCOPE-838] review of syncope-enduser's lo...
GitHub user mteo opened a pull request:
https://github.com/apache/syncope/pull/14
[SYNCOPE-838] review of syncope-enduser's logs
logging messages cleaning, syntax and logging level review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mteo/syncope SYNCOPE-838
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/syncope/pull/14.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14
----
commit 17b12412ffec3a205a753556c444820121a5cfe7
Author: Matteo Di Carlo <ma...@bhuman.it>
Date: 2016-05-03T14:04:56Z
[SYNCOPE-838] review of syncope-enduser's logs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] syncope pull request: [SYNCOPE-838] review of syncope-enduser's lo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/syncope/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] syncope pull request: [SYNCOPE-838] review of syncope-enduser's lo...
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on a diff in the pull request:
https://github.com/apache/syncope/pull/14#discussion_r61889125
--- Diff: client/enduser/src/main/resources/META-INF/resources/app/js/controllers/LoginController.js ---
@@ -76,19 +76,19 @@ angular.module("login").controller("LoginController", ['$scope', '$rootScope', '
$scope.errorAPI = function () {
$http.get("/syncope-enduser/api/error").success(function (data) {
- console.log("errorAPI response: ", data);
+ console.debug("errorAPI response: ", data);
});
};
$scope.sampleAPI = function () {
$http.get("/syncope-enduser/api/user-self").success(function (data) {
- console.log("sampleAPI response: ", data);
+ console.debug("sampleAPI response: ", data);
});
};
$scope.schemaAPI = function () {
$http.get("/syncope-enduser/api/schema").success(function (data) {
- console.log("schemaAPI response: ", data);
+ console.debuXg("schemaAPI response: ", data);
--- End diff --
typo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] syncope pull request: [SYNCOPE-838] review of syncope-enduser's lo...
Posted by mteo <gi...@git.apache.org>.
Github user mteo commented on the pull request:
https://github.com/apache/syncope/pull/14#issuecomment-216554285
ok. I fixed the java logs.
Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] syncope pull request: [SYNCOPE-838] review of syncope-enduser's lo...
Posted by ilgrosso <gi...@git.apache.org>.
Github user ilgrosso commented on the pull request:
https://github.com/apache/syncope/pull/14#issuecomment-216546800
Nice job @mteo - could you please also review the Java code in a similar fashion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---