[GitHub] [airflow] anthonyjgraff commented on a diff in pull request #22965: Upgrade to support Google Ads v10

[GitBox <gi...@apache.org>]

anthonyjgraff commented on code in PR #22965:
URL: https://github.com/apache/airflow/pull/22965#discussion_r850128387


##########
setup.cfg:
##########
@@ -91,7 +91,7 @@ install_requires =
     # Cattrs upgrades were known to break lineage https://github.com/apache/airflow/issues/16172
     # TODO: Cattrs is now at 3.8 version so we should attempt to upgrade cattrs soon.
     cattrs~=1.1, !=1.7.*
-    colorlog>=4.0.2
+    colorlog>=4.0.2, <5.0

Review Comment:
   It felt fixable when I first spotted it yesterday - the issues all seemed to be related to `CustomTTYColoredFormatter` but it didn't feel right to make changes to Airflow logging as part of this PR, as it's totally unrelated to Google Ads
   
   It was actually mypy that threw up errors - the `TTYColoredFormatter` class we inherit from was merged into `ColoredFormatter`, and as a result, a few functions have changed names / signatures.
   
   Can introduce a comment as part of this PR, and can look to upgrade it in a separate PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org