[jira] [Commented] (THRIFT-2894) PHP json serializer skips maps with int/bool keys

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248113#comment-14248113 ] 

ASF GitHub Bot commented on THRIFT-2894:
----------------------------------------

GitHub user stigsb opened a pull request:

    https://github.com/apache/thrift/pull/320

    PHP generator: in jsonSerialize, only skip maps with non-scalar keys

    (previously skipped maps with non-string keys)
    Jira ticket: THRIFT-2894


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stigsb/thrift THRIFT-2894

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/320.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #320
    
----
commit 5914cf3c5c552c8d7641add4e596884ce2c59da4
Author: Stig Bakken <st...@zedge.net>
Date:   2014-12-12T11:49:47Z

    PHP generator: in jsonSerialize, only skip maps with non-scalar keys
    (previously skipped maps with non-string keys)

----


> PHP json serializer skips maps with int/bool keys
> -------------------------------------------------
>
>                 Key: THRIFT-2894
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2894
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Stig Bakken
>            Priority: Minor
>
> When the PHP generator runs with the "json" option, it skips fields that are maps with non-string keys. An instance of this struct will produce an empty object when JSON-serialized:
> {code}struct Foo {
>   1: map<i32,string>;
> }{code}
> This is unnecessarily strict, since PHP's json_encode() function will convert the keys to strings for you.
> Pull request coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)