You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by 10110346 <gi...@git.apache.org> on 2018/10/19 07:07:14 UTC

[GitHub] spark pull request #22774: [SPARK-25780][CORE]Scheduling the tasks which hav...

GitHub user 10110346 opened a pull request:

    https://github.com/apache/spark/pull/22774

    [SPARK-25780][CORE]Scheduling the tasks which have no higher level locality first

    ## What changes were proposed in this pull request?
    For example:
    An application has two executors: (exe1, host1), (exe2,host2), and 3 tasks with locality:  {task0, Seq(TaskLocation("host1", "exec1"))}, {task1, Seq(TaskLocation("host1", "exec1"), TaskLocation("host2"))},  {task2, Seq(TaskLocation("host2")}
    
    If task0 is runing in exe1, when `allowedLocality` is NODE_LOCAL for exe2, it is better to schedule task2 fisrt, not task1, because task1 may be scheduled to exe1 later.
    
    ## How was this patch tested?
    Added a UT


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/10110346/spark higher_locality

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22774
    
----
commit 7076bdef5c633739a17e6e9f7ed0c80ed5cb11de
Author: liuxian <li...@...>
Date:   2018-10-19T06:36:30Z

    fix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4119/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97611/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    **[Test build #97611 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97611/testReport)** for PR 22774 at commit [`7076bde`](https://github.com/apache/spark/commit/7076bdef5c633739a17e6e9f7ed0c80ed5cb11de).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by 10110346 <gi...@git.apache.org>.
Github user 10110346 commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    retest this please


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    Merged build finished. Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    **[Test build #97611 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97611/testReport)** for PR 22774 at commit [`7076bde`](https://github.com/apache/spark/commit/7076bdef5c633739a17e6e9f7ed0c80ed5cb11de).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/97596/
    Test FAILed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/4129/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    **[Test build #97596 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97596/testReport)** for PR 22774 at commit [`7076bde`](https://github.com/apache/spark/commit/7076bdef5c633739a17e6e9f7ed0c80ed5cb11de).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    **[Test build #97596 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/97596/testReport)** for PR 22774 at commit [`7076bde`](https://github.com/apache/spark/commit/7076bdef5c633739a17e6e9f7ed0c80ed5cb11de).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #22774: [SPARK-25780][CORE]Scheduling the tasks which have no hi...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/22774
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org