[jira] [Commented] (ORC-429) Refactor code in TypeImpl.cc

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670876#comment-16670876 ] 

ASF GitHub Bot commented on ORC-429:
------------------------------------

fangzheng opened a new pull request #333: ORC-429: [C++] Refactor code in TypeImpl.cc
URL: https://github.com/apache/orc/pull/333
 
 
   1. In convertType() function: in the case of proto::Type_Kind_STRUCT, two vectors are created but never used. They shall be removed.
   
   2. In TypeImpl::parseType() function: the function calls input.substr() to copy the substring before parsing it. This string copy can be avoided by directly parsing on the input string. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactor code in TypeImpl.cc
> ----------------------------
>
>                 Key: ORC-429
>                 URL: https://issues.apache.org/jira/browse/ORC-429
>             Project: ORC
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Fang Zheng
>            Priority: Minor
>
> Propose to make two changes to the code in TypeImpl.cc
>  
> 1. In convertType() function: in the case of proto::Type_Kind_STRUCT, two vectors are created but never used. They shall be removed.
> 2. In TypeImpl::parseType() function: the function calls input.substr() to copy the substring before parsing it. This string copy can be avoided by directly parsing on the input string. Please see pull request for details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)