You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/09 04:07:17 UTC

[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2385: [Feature][Connector-V2] Add json file sink & json format

hailin0 commented on PR #2385:
URL: https://github.com/apache/incubator-seatunnel/pull/2385#issuecomment-1208886682

   > +1 JsonFile Connector is Ok, But it seems you have added some code not necessary for this Connector. For example `JsonFormatFactory` . @CalvinKirs @ashulin please have look.
   
   Yes, now added  `JsonFormatFeactory`  but it's not completed. 
   `SeaTunnelRow` serialization to other formats should use the `format` attribute to selected format factory


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org