You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "vsop-479 (via GitHub)" <gi...@apache.org> on 2025/06/19 09:50:32 UTC
[PR] Use PriorityQueue instead of TreeMap in FirstPassGroupingCollector. [lucene]
vsop-479 opened a new pull request, #14813:
URL: https://github.com/apache/lucene/pull/14813
### Description
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use PriorityQueue instead of TreeMap in FirstPassGroupingCollector. [lucene]
Posted by "vsop-479 (via GitHub)" <gi...@apache.org>.
vsop-479 commented on PR #14813:
URL: https://github.com/apache/lucene/pull/14813#issuecomment-2990790159
I added a new benchmark (`FirstPassGroupingBenchmark`) to simulate `FirstPassGroupingCollector` 's implementation.
It seems use heap can gain a better performance:
```
Benchmark Mode Cnt Score Error Units
FirstPassGroupingBenchmark.getTopNWithHeap thrpt 15 0.010 ± 0.002 ops/us
FirstPassGroupingBenchmark.getTopNWithTreeMap thrpt 15 0.005 ± 0.001 ops/us
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use PriorityQueue instead of TreeMap in FirstPassGroupingCollector. [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14813:
URL: https://github.com/apache/lucene/pull/14813#issuecomment-2987467232
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use PriorityQueue instead of TreeMap in FirstPassGroupingCollector. [lucene]
Posted by "vsop-479 (via GitHub)" <gi...@apache.org>.
vsop-479 commented on PR #14813:
URL: https://github.com/apache/lucene/pull/14813#issuecomment-2987535916
Benchmark:
```
Benchmark Mode Cnt Score Error Units
PriorityQueueBenchmark.getTopNWithHeap thrpt 15 ≈ 10⁻³ ops/us
PriorityQueueBenchmark.getTopNWithTreeMap thrpt 15 ≈ 10⁻⁴ ops/us
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use PriorityQueue instead of TreeMap in FirstPassGroupingCollector. [lucene]
Posted by "vsop-479 (via GitHub)" <gi...@apache.org>.
vsop-479 commented on PR #14813:
URL: https://github.com/apache/lucene/pull/14813#issuecomment-2999202574
Emm~, Use heap will remove(pop) element in orderedGroups, which will result in `TestGrouping#testRandom` fail, since this test case `getTopGroups` many times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Use PriorityQueue instead of TreeMap in FirstPassGroupingCollector. [lucene]
Posted by "vsop-479 (via GitHub)" <gi...@apache.org>.
vsop-479 closed pull request #14813: Use PriorityQueue instead of TreeMap in FirstPassGroupingCollector.
URL: https://github.com/apache/lucene/pull/14813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org