You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "jbampton (via GitHub)" <gi...@apache.org> on 2025/10/20 08:53:20 UTC

[I] `lychee` pre-commit run: `Catch Broken Links in Seconds` [cloudstack]

jbampton opened a new issue, #11867:
URL: https://github.com/apache/cloudstack/issues/11867

   refs https://github.com/apache/cloudstack/issues/11290
   
   https://lychee.cli.rs/
   
   So we have some broken links, others that should point to the direct links and some that need ignoring in the lychee config `lychee.toml`
   
   My local config was:
   
   ```
     - repo: https://github.com/lycheeverse/lychee.git
       rev: lychee-v0.20.1
       hooks:
         - id: lychee
           name: run lychee
           description: run lychee a fast, async, stream-based link checker written in Rust
           args: [--config=.github/linters/lychee.toml]
           files: \.md$
   ```
   
   pre-commit run output:
   
   ```
   run lychee...............................................................Failed
   - hook id: lychee
   - exit code: 2
   
     660/660 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links                        Issues found in 6 inputs. Find details below.
                                                                                                                                                                                                                             
   [CHANGES.md]:                                                                                                                                                                                                             
        [404] https://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.2.1/html/Release_Notes/version-4.2.html#issues-fixed-4.2.1 | Network error: Not Found                                                             
        [404] https://cloudstack.apache.org/docs/en-US/Apache_CloudStack/4.2.0/html/Release_Notes/index.html | Network error: Not Found
   
   [tools/devcloud4/README.md]:
        [429] https://www.vagrantup.com/downloads.html | Network error: Too Many Requests                                                                                                                                    
        [404] https://downloads.chef.io/chef-dk/ | Network error: Not Found
   
   [INSTALL.md]:
      [ERROR] http://localhost:5050/ | Network error: error sending request for url (http://localhost:5050/) Maybe a certificate error?                                                                                      
   
   [ui/README.md]:
        [404] https://viserjs.github.io/docs.html#/viser/guide/installation | Network error: Not Found                                                                                                                       
    [TIMEOUT] https://markmail.org/message/vxnskmwhfaagnm4r | Timeout
        [404] https://iconka.com/en/downloads/cat-power/ | Network error: Not Found
    [TIMEOUT] https://markmail.org/message/bgnn4xkjnlzseeuv | Timeout
   
   [CONTRIBUTING.md]:
        [404] https://github.com/YOUR_ACCOUNT/cloudstack | Network error: Not Found                                                                                                                                          
   
   [README.md]:
        [404] https://cloudstack.apache.org/survey.html | Network error: Not Found                                                                                                                                           
   
   🔍 660 Total (in 47s) ✅ 641 OK 🚫 10 Errors 👻 6 Excluded ⏳ 2 Timeouts
      [WARN ] There were issues with GitHub URLs. You could try setting a GitHub token and running lychee again.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `lychee` pre-commit run: `Catch Broken Links in Seconds` [cloudstack]

Posted by "RosiKyu (via GitHub)" <gi...@apache.org>.
RosiKyu commented on issue #11867:
URL: https://github.com/apache/cloudstack/issues/11867#issuecomment-5993832461

   @jbampton do you have any plans to work on this for 24.0?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `lychee` pre-commit run: `Catch Broken Links in Seconds` [cloudstack]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #11867:
URL: https://github.com/apache/cloudstack/issues/11867#issuecomment-4059184137

   This issue is stale because it has been open for 120 days with no activity. It may be removed by administrators of this project at any time. Remove the stale label or comment to request for removal of it to prevent this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `lychee` pre-commit run: `Catch Broken Links in Seconds` [cloudstack]

Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on issue #11867:
URL: https://github.com/apache/cloudstack/issues/11867#issuecomment-4071737117

   That is correct @DaanHoogland I hit that same problem trying to use lychee with pre-commit on another project.
   
   Normally the hooks should be self contained and they should not need binaries etc to be installed locally.
   
   When I first tested it worked with pre-commit since I had lychee globally installed previously.
   
   I only hit the bug when I uninstalled lychee from my PC.
   
   Seems others are hitting the same problem
   
   https://github.com/lycheeverse/lychee/issues/1635
   
   But there is a new solution since the lychee action has been added as an approved ASF action by infra.
   
   https://github.com/apache/infrastructure-actions/pull/518
   
   See more discussion here:
   
   https://github.com/apache/sedona/pull/2727


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `lychee` pre-commit run: `Catch Broken Links in Seconds` [cloudstack]

Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on issue #11867:
URL: https://github.com/apache/cloudstack/issues/11867#issuecomment-4073528922

   Yes it is a separate workflow and not part of the pre-commit hooks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `lychee` pre-commit run: `Catch Broken Links in Seconds` [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #11867:
URL: https://github.com/apache/cloudstack/issues/11867#issuecomment-4067154118

   @jbampton , I had to install lychee locally and using the default lychee.toml it worked immediatly. What is your idea we should do? (not running ubuntu!)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `lychee` pre-commit run: `Catch Broken Links in Seconds` [cloudstack]

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #11867:
URL: https://github.com/apache/cloudstack/issues/11867#issuecomment-4829679339

   moving to 4.24.0 milestone


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] `lychee` pre-commit run: `Catch Broken Links in Seconds` [cloudstack]

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #11867:
URL: https://github.com/apache/cloudstack/issues/11867#issuecomment-4073397523

   ok, seems doable @jbampton , but it does mean it will have to be a separate workflow if I read it correctly. as in not part of the pre-commit flow. Is that correct?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org