[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #1414: DISPATCH-2247: Added router id to log message

[GitBox <gi...@apache.org>]

ted-ross commented on a change in pull request #1414:
URL: https://github.com/apache/qpid-dispatch/pull/1414#discussion_r740289212



##########
File path: src/router_core/modules/mobile_sync/mobile.c
##########
@@ -690,8 +690,24 @@ static void qcm_mobile_sync_on_mau_CT(qdrm_mobile_sync_t *msync, qd_parsed_field
             // Tell the python router about the new mobile sequence
             //
             qdr_post_set_mobile_seq_CT(msync->core, router->mask_bit, mobile_seq);
-        } else
-            qd_log(msync->log, QD_LOG_ERROR, "Received MAU from an unknown router");
+        } else {
+            //
+            // There is a possibility here that router_id is null but that is fine. We want to print it out either way
+            // which will help us in debugging.
+            //
+            char *r_id = 0;
+            bool free_rid = false;

Review comment:
       You don't need the free_rid thing.  It is safe to call 'free' on a null pointer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org