You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "AtesComp (via GitHub)" <gi...@apache.org> on 2025/12/08 23:32:27 UTC

[PR] Update Fuseki Edit view CodeMirror usage [jena]

AtesComp opened a new pull request, #3629:
URL: https://github.com/apache/jena/pull/3629

   * Create CodeMirror component for abstraction
   * Replace Edit.vue textarea to CodeMirror element
   * Update jena-fuseki-ui package.json to support native legacy mode languages
   
   GitHub issue resolved #3555
   
   Pull request Description:
   Fixes Fuseki UI graph edit contents for save.
   
   
   ----
   
    - [ ] Tests are included.
    - [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
    - [ ] Commits have been squashed to remove intermediate development commit messages.
    - [ ] Key commit messages start with the issue number (GH-xxxx)
   
   By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
   
   ----
   
   See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

Re: [PR] Update Fuseki Edit view CodeMirror usage [jena]

Posted by "AtesComp (via GitHub)" <gi...@apache.org>.
AtesComp commented on PR #3629:
URL: https://github.com/apache/jena/pull/3629#issuecomment-3638807558

   On it. It'll be updated shortly.
   I've added a .gitignore entry for VSCode as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

Re: [PR] Update Fuseki Edit view CodeMirror usage [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #3629:
URL: https://github.com/apache/jena/pull/3629#issuecomment-3661975770

   One small request - could you squash the commits down to one please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

Re: [PR] Update Fuseki Edit view CodeMirror usage [jena]

Posted by "AtesComp (via GitHub)" <gi...@apache.org>.
AtesComp closed pull request #3629: Update Fuseki Edit view CodeMirror usage
URL: https://github.com/apache/jena/pull/3629


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org

Re: [PR] Update Fuseki Edit view CodeMirror usage [jena]

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on PR #3629:
URL: https://github.com/apache/jena/pull/3629#issuecomment-3636442032

   Hi @AtesComp - good to see this PR!
   
   I downloaded the PR and ran the Jena build (`mvn clean install`) which came across two issues:
   
   1.The file `jena-fuseki2/jena-fuseki-ui/src/components/dataset/CodeMirror.vue` needs a license header comment (see other files in the same directory).
   
   2. The yarn.lock file is not in-step with packages.json. 
   
   With workarounds for those two points, the build+tests works.
   
   Also - please could you rebase the code to the latest state of `main` because today is our "javascript dependencies update day" from dependabot and today's batch changed `yarn.lock`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org