[PR] CAMEL-22083: FTP [camel]

["Croway (via GitHub)" <gi...@apache.org>]

Croway opened a new pull request, #18109:
URL: https://github.com/apache/camel/pull/18109

   When using `camel infra run $SERVICE` the resulting json properties should match the Camel ones. For example, right now `camel infra run ftp` print
   ```
   {
     "getFtpRootDir" : "file:///private/tmp/test/target/ftp/camel-test-infra-test-directory/camel-test-infra-configuration-test-directory",
     "getPort" : 49894
   } 
   ```
   This json has some issues:
   
   * Wrong naming convention, getPort should be port to match the property in Camel
   * The hostname is missing (in this case can be a constant, localhost)
   * The directoryName is missing as well (any constant string would be ok)
   * Username and password are needed as well since the underlying implementation needs those.
   
   This way, the command will be tool-friendly and tools may automagically configure routes for fast prototyping.
   
   With the fix, the following is printed:
   
   ```
   {
     "directoryName" : "myTestDirectory",
     "getFtpRootDir" : "file:///Users/fmariani/Repositories/croway/camel/target/ftp/camel-test-infra-test-directory/camel-test-infra-configuration-test-directory",
     "getPort" : 54556,
     "hostname" : "localhost",
     "password" : "admin",
     "port" : 54556,
     "username" : "admin"
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-22083: FTP [camel]

["Croway (via GitHub)" <gi...@apache.org>]

Croway merged PR #18109:
URL: https://github.com/apache/camel/pull/18109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org