You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2014/04/29 14:16:15 UTC
[jira] [Updated] (LUCENE-5591) ReaderAndUpdates should create a
proper IOContext when writing DV updates
[ https://issues.apache.org/jira/browse/LUCENE-5591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera updated LUCENE-5591:
-------------------------------
Attachment: LUCENE-5591.patch
Patch adds an approximation flush size:
* DocValuesFieldUpdates.avgUpdateSize, implemented by both Numeric and Binary.
* ReaderAndUpdates creates a FlushInfo w/ the total avgUpdateSize (over all fields) x maxDoc as an approximation. I also approximated the size of the FIS.
* Added two tests to TestNumeric/BinaryDVUpdates using NRTCachingDirectory, making sure that we don't pass IOContext.DEFAULT (ensuring there are no cached files after applying an update).
I think it's ready.
> ReaderAndUpdates should create a proper IOContext when writing DV updates
> -------------------------------------------------------------------------
>
> Key: LUCENE-5591
> URL: https://issues.apache.org/jira/browse/LUCENE-5591
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Shai Erera
> Attachments: LUCENE-5591.patch
>
>
> Today we pass IOContext.DEFAULT. If DV updates are used in conjunction w/ NRTCachingDirectory, it means the latter will attempt to write the entire DV field in its RAMDirectory, which could lead to OOM.
> Would be good if we can build our own FlushInfo, estimating the number of bytes we're about to write. I didn't see off hand a quick way to guesstimate that - I thought to use the current DV's sizeInBytes as an approximation, but I don't see a way to get it, not a direct way at least.
> Maybe we can use the size of the in-memory updates to guesstimate that amount? Something like {{sizeOfInMemUpdates * (maxDoc/numUpdatedDocs)}}? Is it a too wild guess?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org