[GitHub] [commons-imaging] gwlucastrig commented on a change in pull request #72: IMAGING-251 support for TIFF floating-point formats

[GitBox <gi...@apache.org>]

gwlucastrig commented on a change in pull request #72: IMAGING-251 support for TIFF floating-point formats
URL: https://github.com/apache/commons-imaging/pull/72#discussion_r405469411
 
 

 ##########
 File path: src/main/java/org/apache/commons/imaging/formats/tiff/datareaders/DataReaderStrips.java
 ##########
 @@ -166,7 +166,7 @@ private void interpretStrip(
         // this logic will handle all cases not conforming to the
         // special case handled above
 
-        try (final BitInputStream bis = new BitInputStream(new ByteArrayInputStream(bytes), byteOrder)) {
+        try (BitInputStream bis = new BitInputStream(new ByteArrayInputStream(bytes), byteOrder)) {
 
 Review comment:
   This is one of the changes I made based on the PMD recommendations.  Would it be better if I put the "final" modifier back in?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services