[GitHub] [pinot] siddharthteotia commented on a diff in pull request #9597: [hotfix][multistage] support filter boolean ref & literal

[GitBox <gi...@apache.org>]

siddharthteotia commented on code in PR #9597:
URL: https://github.com/apache/pinot/pull/9597#discussion_r997597588


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/operands/FilterOperand.java:
##########
@@ -95,6 +114,36 @@ public Boolean apply(Object[] row) {
   @Override
   public abstract Boolean apply(Object[] row);
 
+  private static class BooleanInputRef extends FilterOperand {
+    private final RexExpression.InputRef _inputRef;
+
+    public BooleanInputRef(RexExpression.InputRef inputRef, DataSchema dataSchema) {
+      Preconditions.checkState(dataSchema.getColumnDataType(inputRef.getIndex())
+          == DataSchema.ColumnDataType.BOOLEAN);
+      _inputRef = inputRef;
+    }
+
+    @Override
+    public Boolean apply(Object[] row) {
+      return row[_inputRef.getIndex()] instanceof Integer ? (Integer) row[_inputRef.getIndex()] > 0

Review Comment:
   May not be a big deal but is there no way to avoid `instanceof` check ? Could be costly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org