You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/27 15:08:44 UTC
[GitHub] [rocketmq] 123monkey opened a new pull request, #4222: format code KVConfigManager
123monkey opened a new pull request, #4222:
URL: https://github.com/apache/rocketmq/pull/4222
format code KVConfigManager
**Make sure set the target branch to `develop`**
## What is the purpose of the change
format code KVConfigManager.java
## Brief changelog
format code KVConfigManager.java
## Verifying this change
import org.apache.rocketmq.namesrv.NamesrvController;
public class KVConfigManager {
change to
import org.apache.rocketmq.namesrv.NamesrvController;
public class KVConfigManager {
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] HScarb commented on pull request #4222: format code KVConfigManager
Posted by GitBox <gi...@apache.org>.
HScarb commented on PR #4222:
URL: https://github.com/apache/rocketmq/pull/4222#issuecomment-1111641712
Line 38 can be simplified to
```java
new HashMap<>();
```
would you like to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] francisoliverlee merged pull request #4222: format code KVConfigManager
Posted by GitBox <gi...@apache.org>.
francisoliverlee merged PR #4222:
URL: https://github.com/apache/rocketmq/pull/4222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org