You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/07 20:31:29 UTC

[GitHub] [incubator-superset] rusackas commented on a change in pull request #11163: refactor: Replace usages of Popover from react-bootstrap with Antd

rusackas commented on a change in pull request #11163:
URL: https://github.com/apache/incubator-superset/pull/11163#discussion_r501291210



##########
File path: superset-frontend/stylesheets/antd/index.less
##########
@@ -21,10 +21,6 @@
 @import '~antd/lib/style/mixins/index';
 @import '~antd/lib/style/core/base';
 
-*[class*='ant-'] {

Review comment:
       I *think* the reason this was included is so that the color variables below it in the code are inserted into the global styles. Can you confirm whether or not these colors are still being applied to elements correctly?
   
   That said, I'm _really_ hoping to kill off LESS variables at some point, so everything uses variables pulled in from the Emotion Theme... maybe this is the time to start looking at a better way (Emotion or otherwise) to import/use the Theme colors for all the AntD components we're now using. Thoughts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org