You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@eagle.apache.org by BruceKuiLiu <gi...@git.apache.org> on 2018/04/21 20:33:11 UTC

[GitHub] eagle pull request #991: EAGLE-1088: Change the inconsistent method name 'fi...

GitHub user BruceKuiLiu opened a pull request:

    https://github.com/apache/eagle/pull/991

    EAGLE-1088: Change the inconsistent method name 'find'.

    Change the method name 'find' to 'isMatched'.
    The method is named "find", but the method does not find anything, just returns a boolean-variable 'this.matched'. Thus, rename method as "isMatched" should be more clear than "find".

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/BruceKuiLiu/eagle master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/eagle/pull/991.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #991
    
----
commit 86e564bab1f9ec52cc653fd04a00f7893ba7a8c1
Author: Kui LIU <br...@...>
Date:   2018-04-21T20:28:19Z

    Change the method name 'find' to 'isMatched'.

----


---

[GitHub] eagle issue #991: EAGLE-1088: Change the inconsistent method name 'find'.

Posted by jhsenjaliya <gi...@git.apache.org>.

Github user jhsenjaliya commented on the issue:

    https://github.com/apache/eagle/pull/991
  
    @BruceKuiLiu, I believe this is consistent with Java.Pattern class method where find will return true/false based on pattern match. 
    I would let @yonzhang comment further on this. 
    Thanks for the PR though. 


---

[GitHub] eagle pull request #991: EAGLE-1088: Change the inconsistent method name 'fi...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/eagle/pull/991


---