You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/26 07:19:18 UTC

[GitHub] [doris] jackwener commented on a diff in pull request #11035: [Feature](nereids) support sub-query and alias for TPC-H

jackwener commented on code in PR #11035:
URL: https://github.com/apache/doris/pull/11035#discussion_r929609084


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -118,6 +121,38 @@ private Plan groupToTreeNode(Group group) {
         return result.withChildren(childrenNode);
     }
 
+    private static class GroupExpressionAdapter {
+        private final GroupExpression groupExpr;
+
+        public GroupExpressionAdapter(GroupExpression groupExpr) {
+            this.groupExpr = groupExpr;
+        }
+
+        public GroupExpression getGroupExpr() {
+            return groupExpr;
+        }
+
+        @Override
+        public boolean equals(Object o) {
+            if (this == o) {
+                return true;
+            }
+            if (o == null || getClass() != o.getClass()) {
+                return false;
+            }
+            GroupExpressionAdapter that = (GroupExpressionAdapter) o;
+            if (that.groupExpr.getPlan() instanceof LogicalOlapScan) {

Review Comment:
   why special judgment for `OlapScan`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org