You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/07 22:08:10 UTC
[GitHub] [tvm] areusch opened a new pull request #7227: [BUGFIX] Change debug_runtime to represent times in seconds internally
areusch opened a new pull request #7227:
URL: https://github.com/apache/tvm/pull/7227
Follow-on to #7197 and #6964, and fix #7207.
DebugRuntime used to represent runtimes as doubles but in microseconds. An unintentionally merged part of #6964 migrated the timing parts to use seconds, but the display parts continued to use microseconds. This patch completes the migration and adds a test. We don't have to migrate this, but it's weird to me to store runtime in double, but not store it in seconds. At least, the units should be made clear in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jcf94 merged pull request #7227: [BUGFIX] Change debug_runtime to represent times in seconds internally
Posted by GitBox <gi...@apache.org>.
jcf94 merged pull request #7227:
URL: https://github.com/apache/tvm/pull/7227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #7227: [BUGFIX] Change debug_runtime to represent times in seconds internally
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #7227:
URL: https://github.com/apache/tvm/pull/7227#issuecomment-756419891
@tqchen @junrushao1994 @FrozenGene
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jcf94 commented on pull request #7227: [BUGFIX] Change debug_runtime to represent times in seconds internally
Posted by GitBox <gi...@apache.org>.
jcf94 commented on pull request #7227:
URL: https://github.com/apache/tvm/pull/7227#issuecomment-756487144
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org