You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "taklwu (via GitHub)" <gi...@apache.org> on 2023/02/08 06:36:44 UTC
[GitHub] [hbase] taklwu commented on a diff in pull request #5014: HBASE-27619 Bulkload fails when trying to bulkload files with invalid names after HBASE-26707
taklwu commented on code in PR #5014:
URL: https://github.com/apache/hbase/pull/5014#discussion_r1099715495
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -7280,7 +7280,7 @@ public Map<byte[], List<Path>> bulkLoadHFiles(Collection<Pair<byte[], String>> f
reqTmp ? null : fs.getRegionDir().toString());
}
Pair<Path, Path> pair = null;
- if (reqTmp) {
+ if (reqTmp || (!StoreFileInfo.isHFile(finalPath))) {
Review Comment:
nit: maybe remove the extra `()` ?
```suggestion
if (reqTmp || !StoreFileInfo.isHFile(finalPath)) {
```
do you have any stacktrace and example of the non-HFile ? also , when you said `has been split in the bulkload process` , what would this split generate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org