You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gene-db (via GitHub)" <gi...@apache.org> on 2024/03/15 21:09:37 UTC
[PR] [SPARK-45891] Update README with more details [spark]
gene-db opened a new pull request, #45539:
URL: https://github.com/apache/spark/pull/45539
### What changes were proposed in this pull request?
Update the README with more details.
### Why are the changes needed?
Make the README more reader-friendly.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
n/a
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45891][DOCS] Update README with more details [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #45539: [SPARK-45891][DOCS] Update README with more details
URL: https://github.com/apache/spark/pull/45539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45891][DOCS] Update README with more details [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #45539:
URL: https://github.com/apache/spark/pull/45539#issuecomment-2002810614
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45891] Update README with more details [spark]
Posted by "gene-db (via GitHub)" <gi...@apache.org>.
gene-db commented on PR #45539:
URL: https://github.com/apache/spark/pull/45539#issuecomment-2000446065
@dtenedor @cloud-fan Can you help review this README update? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45891][DOCS] Update README with more details [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #45539:
URL: https://github.com/apache/spark/pull/45539#discussion_r1527731419
##########
common/variant/README.md:
##########
@@ -15,6 +15,55 @@ Another motivation for the representation is that (aside from metadata) each inn
# Metadata encoding
+The encoded metadata always starts with a header byte.
+```
+ 7 6 5 4 3 0
+ +-------+---+---+---------------+
+header | | | | version |
Review Comment:
so the bit 5 is unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org