You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/05 08:56:54 UTC

[GitHub] [spark] cloud-fan commented on pull request #33212: [SPARK-35912][SQL] Fix nullability of `spark.read.json`

cloud-fan commented on pull request #33212:
URL: https://github.com/apache/spark/pull/33212#issuecomment-873934648


   > should return a default value instead of null for the primitive type
   
   I don't agree with this. It's a correctness bug if an integer value is null in the JSON file but Spark read it as 0. We should fail at runtime. We can either do this null check in the jackson parser, or leverage the `AssertNotNull` expression.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org