You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directmemory.apache.org by no...@apache.org on 2012/10/28 18:36:31 UTC
svn commit: r1403050 - in /directmemory/trunk:
directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheService.java
directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheServiceImpl.java
src/site/apt/simple-usage.apt.vm
Author: noctarius
Date: Sun Oct 28 17:36:31 2012
New Revision: 1403050
URL: http://svn.apache.org/viewvc?rev=1403050&view=rev
Log:
Added Closeable as a new extending interface of CacheService because some of the underlying MemoryManager implementations could need some closing logic to clean up successfully
Modified:
directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheService.java
directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheServiceImpl.java
directmemory/trunk/src/site/apt/simple-usage.apt.vm
Modified: directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheService.java
URL: http://svn.apache.org/viewvc/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheService.java?rev=1403050&r1=1403049&r2=1403050&view=diff
==============================================================================
--- directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheService.java (original)
+++ directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheService.java Sun Oct 28 17:36:31 2012
@@ -19,20 +19,20 @@ package org.apache.directmemory.cache;
* under the License.
*/
-
import org.apache.directmemory.memory.MemoryManagerService;
import org.apache.directmemory.memory.Pointer;
import org.apache.directmemory.serialization.Serializer;
+import java.io.Closeable;
import java.util.concurrent.ConcurrentMap;
public interface CacheService<K, V>
+ extends Closeable
{
void scheduleDisposalEvery( long l );
/**
- *
* @param key
* @param payload
* @param expiresIn in ms
@@ -45,7 +45,6 @@ public interface CacheService<K, V>
Pointer<V> put( K key, V value );
/**
- *
* @param key
* @param value
* @param expiresIn in ms
@@ -69,7 +68,6 @@ public interface CacheService<K, V>
void collectAll();
-
void clear();
long entries();
Modified: directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheServiceImpl.java
URL: http://svn.apache.org/viewvc/directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheServiceImpl.java?rev=1403050&r1=1403049&r2=1403050&view=diff
==============================================================================
--- directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheServiceImpl.java (original)
+++ directmemory/trunk/directmemory-cache/src/main/java/org/apache/directmemory/cache/CacheServiceImpl.java Sun Oct 28 17:36:31 2012
@@ -279,6 +279,14 @@ public class CacheServiceImpl<K, V>
}
@Override
+ public void close()
+ throws IOException
+ {
+ memoryManager.close();
+ logger.info( "Cache closed" );
+ }
+
+ @Override
public long entries()
{
return map.size();
Modified: directmemory/trunk/src/site/apt/simple-usage.apt.vm
URL: http://svn.apache.org/viewvc/directmemory/trunk/src/site/apt/simple-usage.apt.vm?rev=1403050&r1=1403049&r2=1403050&view=diff
==============================================================================
--- directmemory/trunk/src/site/apt/simple-usage.apt.vm (original)
+++ directmemory/trunk/src/site/apt/simple-usage.apt.vm Sun Oct 28 17:36:31 2012
@@ -63,10 +63,11 @@ DirectMemory Simple Usage
V retrieve( K key );
+------------------------
- Clear at the end of usage
+ Clear at the end of usage and close the CacheService
+------------------------
- cacheService.clear()
+ cacheService.clear();
+ cacheService.close();
+------------------------