Re: [PR] GH-49232: [Python] deprecate feather python [arrow]

["AlenkaF (via GitHub)" <gi...@apache.org>]

AlenkaF commented on code in PR #49590:
URL: https://github.com/apache/arrow/pull/49590#discussion_r3027896612


##########
docs/source/python/api/formats.rst:
##########
@@ -42,8 +42,11 @@ CSV Files
 
 .. _api.feather:
 
-Feather Files
--------------
+Feather Files (Deprecated)
+--------------------------
+
+.. deprecated:: 24.0.0

Review Comment:
   Could we move this after `currentmodule` directive?



##########
python/pyarrow/tests/test_feather.py:
##########
@@ -882,3 +889,58 @@ def test_feather_datetime_resolution_arrow_to_pandas(tempdir):
 
     assert expected_0 == result['date'][0]
     assert expected_1 == result['date'][1]
+
+
+# --- Deprecation warning tests ---
+
+@pytest.mark.filterwarnings("default:pyarrow.feather:FutureWarning")

Review Comment:
   Can the first three tests be joined into one or is this intentional in order to make it easier to debug failing tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org