You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/07 02:10:08 UTC

[GitHub] [spark] gengliangwang commented on a change in pull request #28841: [SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source

gengliangwang commented on a change in pull request #28841:
URL: https://github.com/apache/spark/pull/28841#discussion_r450572517



##########
File path: examples/src/main/python/sql/datasource.py
##########
@@ -69,6 +69,25 @@ def generic_file_source_options_example(spark):
     # +-------------+
     # $example off:load_with_path_glob_filter$
 
+    # $example on:load_with_modified_date_filter$
+    # Assume file in provided path were last modified today.
+    df = spark.read.load("examples/src/main/resources/dir1",
+                         format="parquet", modifiedDateFilter="2020-06-01T08:30:00")

Review comment:
       Should we specify the timezone here? What should the default timezone be?
   @cloud-fan @MaxGekk 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org