[GitHub] [ignite] sanpwc commented on a change in pull request #7973: IGNITE-13060-tracing-engine

[GitBox <gi...@apache.org>]

sanpwc commented on a change in pull request #7973:
URL: https://github.com/apache/ignite/pull/7973#discussion_r451458735



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/tracing/SpanManager.java
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.tracing;
+
+import org.jetbrains.annotations.NotNull;
+import org.jetbrains.annotations.Nullable;
+
+/**
+ * Manager for {@link Span} instances.
+ */
+public interface SpanManager {

Review comment:
       Tracing is wider abstraction, that also include configuration. In "next" PR https://github.com/apache/ignite/pull/7974 it'll be updated to following state:
   ```
   /**
    * Tracing sub-system interface.
    */
   public interface Tracing extends SpanManager {
       /**
        * @return Helper to handle traceable messages.
        */
       public TraceableMessagesHandler messages();
   
       /**
        * Returns the {@link TracingConfigurationManager} instance that allows to
        * <ul>
        *     <li>Configure tracing parameters such as sampling rate for the specific tracing coordinates
        *          such as scope and label.</li>
        *     <li>Retrieve the most specific tracing parameters for the specified tracing coordinates (scope and label)</li>
        *     <li>Restore the tracing parameters for the specified tracing coordinates to the default.</li>
        *     <li>List all pairs of tracing configuration coordinates and tracing configuration parameters.</li>
        * </ul>
        * @return {@link TracingConfigurationManager} instance.
        */
       public @NotNull TracingConfigurationManager configuration();
   }
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org