You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Kelvin Tan <ke...@relevanz.com> on 2002/12/11 07:49:59 UTC

[jelly] code style

James,

Any chance of code style guidelines for jelly? I noticed you 
reformatted JellyServlet. If you use idea, maybe you can post checkin 
the xml config file for codestyles...

Regards,
Kelvin

--------
The book giving manifesto     - http://how.to/sharethisbook



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [jelly] code style

Posted by Henri Yandell <ba...@generationjava.com>.
Hmm. Would be interesting if Maven generated the checkstyle properties
into a suggested coding standard for a project :)

On Wed, 11 Dec 2002, bob mcwhirter wrote:

> > >Either way, I think checkstyle should alert you to any violations.
> >
> > Not familiar with this. I use Maven to perform the check, I suppose?
> > I saw a couple of declarations in project.properties...
>
> 	maven checkstyle xdoc:transform
>
> That'll generate the checkstyle report for you.
>
> 	maven site:generate
>
> will generate the whole site, including test reports, style reports,
> metrics, code coverage, etc.   Always a good thing to do.
>
> 	-bob
>
>
>
>
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [jelly] code style

Posted by bob mcwhirter <bo...@werken.com>.
> >Either way, I think checkstyle should alert you to any violations.
> 
> Not familiar with this. I use Maven to perform the check, I suppose? 
> I saw a couple of declarations in project.properties...

	maven checkstyle xdoc:transform

That'll generate the checkstyle report for you.

	maven site:generate

will generate the whole site, including test reports, style reports,
metrics, code coverage, etc.   Always a good thing to do.

	-bob




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [jelly] code style

Posted by Kelvin Tan <ke...@relevanz.com>.

On Wed, 11 Dec 2002 01:57:35 -0500 (EST), bob mcwhirter said:
>>Any chance of code style guidelines for jelly? I noticed you
>>reformatted JellyServlet. If you use idea, maybe you can post
>>checkin the xml config file for codestyles...
>
>I think he tends to follow the Sun Coding Conventions, much to the
>irritation of those of us following the more sane Turbine-esque
>conventions, or the perfectly rationalized Werken flavour.
>

+1. But lets not go down this slippery slope. :-)

>Either way, I think checkstyle should alert you to any violations.
>

Not familiar with this. I use Maven to perform the check, I suppose? 
I saw a couple of declarations in project.properties...

# use Sun coding standards

maven.checkstyle.lcurly.type = eol
maven.checkstyle.lcurly.method = eol
maven.checkstyle.lcurly.other = eol
#maven.checkstyle.header.file = src/conf/checkstyle-LICENSE.txt
maven.checkstyle.header.ignore.line = 1,2,3,4,5,6
maven.checkstyle.const.pattern = ^[a-z][a-zA-Z0-9]*$

# disable these non-critical errors to highlight
# more important ones line missing javadoc

maven.checkstyle.max.line.len = 100
maven.checkstyle.ignore.whitespace = true
maven.checkstyle.ignore.public.in.interface = true

>    -bob
>
>
>--
>To unsubscribe, e-mail:   <mailto:commons-dev-
>unsubscribe@jakarta.apache.org> For additional commands, e-mail:
><mailto:commons-dev-
>help@jakarta.apache.org>




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [jelly] code style

Posted by bob mcwhirter <bo...@werken.com>.
> Any chance of code style guidelines for jelly? I noticed you 
> reformatted JellyServlet. If you use idea, maybe you can post checkin 
> the xml config file for codestyles...

I think he tends to follow the Sun Coding Conventions, much to
the irritation of those of us following the more sane Turbine-esque
conventions, or the perfectly rationalized Werken flavour.

Either way, I think checkstyle should alert you to any violations.

	-bob


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>