You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "mariiaKraievska (via GitHub)" <gi...@apache.org> on 2026/04/20 10:28:03 UTC
[PR] FINERACT-2455: WC - Transaction Type - CBR [fineract]
mariiaKraievska opened a new pull request, #5785:
URL: https://github.com/apache/fineract/pull/5785
## Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
- [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Transaction Type - CBR [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5785:
URL: https://github.com/apache/fineract/pull/5785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Transaction Type - CBR [fineract]
Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal commented on PR #5785:
URL: https://github.com/apache/fineract/pull/5785#issuecomment-4295211244
Hi @adamsaghy,
I attempted to review the ticket at https://issues.apache.org/jira/browse/FINERACT-2455
, but I couldn’t find any clearly documented use case or requirements associated with it. I also noticed that several PRs have already been merged under this ticket.
My main concern is that most of the documentation appears to reside within the codebase (e.g., adoc files), rather than being captured in the ticket or on the dev mailing list. Could you please confirm if there are additional discussions or references that should be reviewed?
Since you are leading this feature, it would be very helpful if the implementation scope and requirements were clearly outlined in the ticket to ensure better visibility and alignment for contributors. It would also greatly assist newcomers when reviewing the code and trying to understand or ask questions about the intended use cases.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Transaction Type - CBR [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5785:
URL: https://github.com/apache/fineract/pull/5785#issuecomment-4298939552
```
required: EventMessage<R>
found: EventMessage<CAP#1>
where R,T are type-variables:
R extends Object declared in method <R,T>findByType(T)
T extends Event<R> declared in method <R,T>findByType(T)
where CAP#1 is a fresh type-variable:
CAP#1 extends Object from capture of ?
/home/runner/work/fineract/fineract/fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/WorkingCapitalLoanAccountStepDef.java:1718: error: cannot find symbol
() -> fineractClient.workingCapitalLoanTransactions().retrieveWorkingCapitalLoanTemplate1(loanId, command));
^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Transaction Type - CBR [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5785:
URL: https://github.com/apache/fineract/pull/5785#issuecomment-4296889149
@mariiaKraievska Please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2455: WC - Transaction Type - CBR [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5785:
URL: https://github.com/apache/fineract/pull/5785#issuecomment-4303225521
> Hi @adamsaghy,
>
> I attempted to review the ticket at https://issues.apache.org/jira/browse/FINERACT-2455 , but I couldn’t find any clearly documented use case or requirements associated with it. I also noticed that several PRs have already been merged under this ticket.
>
> My main concern is that most of the documentation appears to reside within the codebase (e.g., adoc files), rather than being captured in the ticket or on the dev mailing list. Could you please confirm if there are additional discussions or references that should be reviewed?
>
> Since you are leading this feature, it would be very helpful if the implementation scope and requirements were clearly outlined in the ticket to ensure better visibility and alignment for contributors. It would also greatly assist newcomers when reviewing the code and trying to understand or ask questions about the intended use cases.
>
> Thanks.
Hi @Aman-Mittal
You are right, we should have some documentation under the Apache Fineract Jira tickets as well. Let me review the umbrella ticket and add the missing informations. In the meantime, the `fineract-doc` and the PR implementation reflects the behaviour (in this case, there is no difference it behaviour, just a different loan product)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org