You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "David Capwell (Jira)" <ji...@apache.org> on 2024/11/06 19:18:00 UTC

[jira] [Commented] (CASSANDRA-20054) Get Harry working on top of Accord and fix various issues found by TopologyMixupTestBase

    [ https://issues.apache.org/jira/browse/CASSANDRA-20054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896071#comment-17896071 ] 

David Capwell commented on CASSANDRA-20054:
-------------------------------------------

||Repo||Branch||Parent Branch||SHA||Status||
|https://github.com/dcapwell/cassandra.git|CASSANDRA-20054|trunk|ce7c64ccd6083c2f01d8bc0fead10846444be943|Unstable

Failed Builds:
||Build||Result||Reason||
| dependency_check    | fail | Found 1 vulnerable dependencies                                                                      |
| jvm-dtest-simulator | fail | Test org.apache.cassandra.simulator.test.HarrySimulatorTest::test-_jdk11 had an error,Test org.apach |
| jvm-upgrade-dtests  | fail | Test org.apache.cassandra.distributed.upgrade.MixedModeFrom3ReplicationTest::testSimpleStrategy-_jdk |
| jvm11-dtests        | fail | Test org.apache.cassandra.distributed.test.accord.AccordBootstrapTest::bootstrapTest-_jdk11 failed,T |
| jvm11-dtests-fuzz   | fail | Test org.apache.cassandra.fuzz.topology.AccordTopologyMixupTest::test-_jdk11 failed                  |
| jvm11-utests        | fail | Test org.apache.cassandra.cql3.RandomSchemaV2Test::test-_jdk11 failed,Test org.apache.cassandra.db.c |
| jvm17-dtests        | fail | Test org.apache.cassandra.distributed.test.accord.AccordBootstrapTest::bootstrapTest-_jdk17 failed,T |
| jvm17-dtests-fuzz   | fail | Test org.apache.cassandra.fuzz.topology.AccordTopologyMixupTest::test-_jdk17 failed,Test org.apache. |
| jvm17-utests        | fail | Test org.apache.cassandra.cql3.RandomSchemaV2Test::test-_jdk17 failed,Test org.apache.cassandra.db.c |
| python-dtests       | fail | Test cqlsh_tests.test_cqlsh.TestCqlsh::cqlsh_tests.py::test_cqlsh::test_describe failed,Test cqlsh_t |
| python-dtests-large | fail | Test materialized_views_test.TestMaterializedViews::materialized_views_test.py::TestMaterializedView |



These are failing on cep-15-accord before the merge, so ignoring for now... will try to get tests closer to 0 in follow up work

> Get Harry working on top of Accord and fix various issues found by TopologyMixupTestBase
> ----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-20054
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20054
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Accord, Test/fuzz
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: NA
>
>         Attachments: ci_summary-trunk-ce7c64ccd6083c2f01d8bc0fead10846444be943.html, result_details-trunk-ce7c64ccd6083c2f01d8bc0fead10846444be943.tar.gz
>
>
> TopologyMixupTestBase has been useful at finding a lot of unexpected issues, and adding Harry on top of Accord at this layer should help validate Accord correctness while also testing stability.
> In running these tests several bugs were found
> 1) vtable showing what txn are blocking the queried table would throw error when txn isn’t known, which is valid (report historic transaction…)
> 2) AccordCommandStore submitted sync requests in a blocking manner, but did this on a CommandStore… this lead to a 5 minute deadlock
> 3) MajorityDepsFetcher would have a deadlock as it triggers waiting notifications while holding the lock, and the waiting callers then access more locks, such as the config service lock
> 4) when restarting and learning about removed nodes, AccordService is not setup yet, so need to pass this through to avoid startup issues
> 5) When accord asks TCM for the epoch history, there were no retries which would cause stability issues during startup
> 6) when learning about min epochs needed for startup, purge all starting epochs that are empty as it isn’t needed and only adds costs for startup
> 7) when nodes leave the cluster we did not start durability sync (this isn’t working, but thats a different issue… durability sync requires ALL which isn’t possible)
> 8) TCM’s getLogEntries method hit an edge case with snapshots where it assumed the API was inclusive, but its exclusive; this caused a gap in epochs
> 9) JVM Dtest now supports startup timeouts, this is to avoid issues where startup will take infinity (due to bugs) causing CI to throw away the logs.
> 10) fixed a race condition bug in Harry where the TokenPlacementModel could see a partial row causing NPEs down the line
> 11) Fixed a bug in Harry where Accord timeouts would not retry as they don’t have the expected message



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org