You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/05/27 13:42:01 UTC
[GitHub] [flink] SteNicholas opened a new pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
SteNicholas opened a new pull request #16013:
URL: https://github.com/apache/flink/pull/16013
## What is the purpose of the change
*In the sql-client, users should submit statements for operation that remove jar as follows:*
```
Flink SQL> REMOVE JAR /local/test.jar;
[Info] The specified jar is removed from session classloader.
```
*`CliClient` should support `REMOVE JAR` syntax in SQL Client.*
## Brief change log
- *Add `RemoveJarOperation` to support `REMOVE JAR` syntax for `CliClient`.*
## Verifying this change
- *`CliClientITCase` adds `REMOVE JARS` cases for `testSqlStatements` to verify whether `CliClient` supports the `REMOVE JAR` syntax.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-852723653
@wuchong , I have rebased master branch and used `SHOW JARS` to verify the implementation for `REMOVE JAR`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas removed a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
SteNicholas removed a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-851465411
> I would prefer to review this PR after #16010 is merged. Then you can use `show jars` to verify `remove jar`.
Yes, I would like to use `show jars` to verify `remove jar` after the above PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87237d1486675216da5e403c4e88a2f22e71552b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-851447145
I would prefer to review this PR after #16010 is merged. Then you can use `show jars` to verify `remove jar`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
}, {
"hash" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538",
"triggerID" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"triggerType" : "PUSH"
}, {
"hash" : "778de66e3ea0ba3b619114c4ef3243644f86b63a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18720",
"triggerID" : "778de66e3ea0ba3b619114c4ef3243644f86b63a",
"triggerType" : "PUSH"
}, {
"hash" : "6a27305fb274139eea73aca4006a54158c83afda",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18738",
"triggerID" : "6a27305fb274139eea73aca4006a54158c83afda",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6a27305fb274139eea73aca4006a54158c83afda Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18738)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849656599
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 6a27305fb274139eea73aca4006a54158c83afda (Thu Sep 23 17:23:34 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
}, {
"hash" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538",
"triggerID" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"triggerType" : "PUSH"
}, {
"hash" : "778de66e3ea0ba3b619114c4ef3243644f86b63a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18720",
"triggerID" : "778de66e3ea0ba3b619114c4ef3243644f86b63a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 63444b536e73773da0f02dab5fe372db958dbbb4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538)
* 778de66e3ea0ba3b619114c4ef3243644f86b63a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18720)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
}, {
"hash" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87237d1486675216da5e403c4e88a2f22e71552b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371)
* 63444b536e73773da0f02dab5fe372db958dbbb4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-851465411
> I would prefer to review this PR after #16010 is merged. Then you can use `show jars` to verify `remove jar`.
Yes, I would like to use `show jars` to verify `remove jar` after the above PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
}, {
"hash" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538",
"triggerID" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87237d1486675216da5e403c4e88a2f22e71552b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371)
* 63444b536e73773da0f02dab5fe372db958dbbb4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-855551833
Hi @SteNicholas , do you have time to update it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #16013:
URL: https://github.com/apache/flink/pull/16013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-855644975
@wuchong , I have addressed your detailed comments and updated this pull request. Could you please help to review again? Sorry for later update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849656599
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 87237d1486675216da5e403c4e88a2f22e71552b (Thu May 27 13:56:34 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21742).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87237d1486675216da5e403c4e88a2f22e71552b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
}, {
"hash" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538",
"triggerID" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 63444b536e73773da0f02dab5fe372db958dbbb4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #16013:
URL: https://github.com/apache/flink/pull/16013#discussion_r643720204
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java
##########
@@ -284,6 +284,20 @@ public void addJar(String jarPath) {
executionContext = new ExecutionContext(sessionConfiguration, classLoader, sessionState);
}
+ public void removeJar(String jarPath) {
+ URL jarURL = getURLFromPath(jarPath);
+ if (!dependencies.contains(jarURL)) {
Review comment:
Would be better to print a warning or message that can't remove the specified jar because the jar path is not found in session classloader.
##########
File path: flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/context/SessionContextTest.java
##########
@@ -273,6 +298,12 @@ private void validateAddJar(String jarPath) throws IOException {
getConfiguration().get(JARS));
}
+ private void validateRemoveJar(String jarPath) {
+ sessionContext.removeJar(jarPath);
Review comment:
We should assert the jarpath is in session context, and then remove it. Otherwise, we don't know whether the remove action is successful or not.
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java
##########
@@ -353,7 +367,7 @@ private URL getURLFromPath(String jarPath) {
Path path = new Path(jarPath);
String scheme = path.toUri().getScheme();
if (scheme != null && !scheme.equals("file")) {
- throw new SqlExecutionException("SQL Client only supports to add local jars.");
+ throw new SqlExecutionException("SQL client only supports the local jar path.");
Review comment:
Would be better to still keep action name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
}, {
"hash" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538",
"triggerID" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"triggerType" : "PUSH"
}, {
"hash" : "778de66e3ea0ba3b619114c4ef3243644f86b63a",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18720",
"triggerID" : "778de66e3ea0ba3b619114c4ef3243644f86b63a",
"triggerType" : "PUSH"
}, {
"hash" : "6a27305fb274139eea73aca4006a54158c83afda",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18738",
"triggerID" : "6a27305fb274139eea73aca4006a54158c83afda",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 778de66e3ea0ba3b619114c4ef3243644f86b63a Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18720)
* 6a27305fb274139eea73aca4006a54158c83afda Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18738)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
}, {
"hash" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538",
"triggerID" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"triggerType" : "PUSH"
}, {
"hash" : "778de66e3ea0ba3b619114c4ef3243644f86b63a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18720",
"triggerID" : "778de66e3ea0ba3b619114c4ef3243644f86b63a",
"triggerType" : "PUSH"
}, {
"hash" : "6a27305fb274139eea73aca4006a54158c83afda",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6a27305fb274139eea73aca4006a54158c83afda",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 63444b536e73773da0f02dab5fe372db958dbbb4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538)
* 778de66e3ea0ba3b619114c4ef3243644f86b63a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18720)
* 6a27305fb274139eea73aca4006a54158c83afda UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18371",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
}, {
"hash" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538",
"triggerID" : "63444b536e73773da0f02dab5fe372db958dbbb4",
"triggerType" : "PUSH"
}, {
"hash" : "778de66e3ea0ba3b619114c4ef3243644f86b63a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "778de66e3ea0ba3b619114c4ef3243644f86b63a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 63444b536e73773da0f02dab5fe372db958dbbb4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=18538)
* 778de66e3ea0ba3b619114c4ef3243644f86b63a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16013: [FLINK-21742][sql-client] Support REMOVE JAR statement in SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16013:
URL: https://github.com/apache/flink/pull/16013#issuecomment-849676995
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "87237d1486675216da5e403c4e88a2f22e71552b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "87237d1486675216da5e403c4e88a2f22e71552b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 87237d1486675216da5e403c4e88a2f22e71552b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org