You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/05 02:29:26 UTC
[GitHub] [pulsar] liangyepianzhou commented on a diff in pull request #15729: [improve][txn] Support ack message list for transaction
liangyepianzhou commented on code in PR #15729:
URL: https://github.com/apache/pulsar/pull/15729#discussion_r913338803
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2704,6 +2722,58 @@ private CompletableFuture<Void> doTransactionAcknowledgeForResponse(MessageId me
}
}
+ private CompletableFuture<Void> doTransactionAcknowledgeForResponse(List<MessageId> messageIds, AckType ackType,
+ ValidationError validationError,
+ Map<String, Long> properties, TxnID txnID) {
+ BitSetRecyclable bitSetRecyclable = null;
+ long ledgerId;
+ long entryId;
+ ByteBuf cmd;
+ long requestId = client.newRequestId();
+ List<MessageIdData> messageIdDataList = new LinkedList<>();
+ for (MessageId messageId : messageIds) {
Review Comment:
Yeah, the broker will check confliction.
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -2704,6 +2722,58 @@ private CompletableFuture<Void> doTransactionAcknowledgeForResponse(MessageId me
}
}
+ private CompletableFuture<Void> doTransactionAcknowledgeForResponse(List<MessageId> messageIds, AckType ackType,
+ ValidationError validationError,
+ Map<String, Long> properties, TxnID txnID) {
+ BitSetRecyclable bitSetRecyclable = null;
+ long ledgerId;
+ long entryId;
+ ByteBuf cmd;
+ long requestId = client.newRequestId();
+ List<MessageIdData> messageIdDataList = new LinkedList<>();
+ for (MessageId messageId : messageIds) {
Review Comment:
Yeah, the broker will check conflication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org