You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/01 10:34:56 UTC
[GitHub] [skywalking] qxo opened a new pull request #5218: add a commons config API for get config key/value by: Config.getProperty
qxo opened a new pull request #5218:
URL: https://github.com/apache/skywalking/pull/5218
with this config API, the external plugin can get config without change the apm-agent-core Config.java.
then using as below:
````
private static final int CUSTOM_CMP_ID = Integer.parseInt(Config.getProperty("ex_plugin_comp_id", "100"));
````
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [*] New feature provided
- [ ] Improve performance
- Related issues
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
添加此通用配置API的目的：
* 为外部扩展插件提供一种统一的方式来存取配置项
* 原来的方式添加配置项要修改Config类的方式不适用于外部插件
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed pull request #5218: add a commons config API for get config key/value by: Config.getProperty
Posted by GitBox <gi...@apache.org>.
wu-sheng closed pull request #5218:
URL: https://github.com/apache/skywalking/pull/5218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] qxo commented on pull request #5218: add a commons config API for get config key/value by: Config.getProperty
Posted by GitBox <gi...@apache.org>.
qxo commented on pull request #5218:
URL: https://github.com/apache/skywalking/pull/5218#issuecomment-669125529
> Don't need that API. All config class could be auto injected. Have you noticed all configs in file are same, but no attributes in the core config class?
此处应该有一链接，给大家给一个：外配插件如何注入配置的样例
Thanks:)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] qxo commented on pull request #5218: add a commons config API for get config key/value by: Config.getProperty
Posted by GitBox <gi...@apache.org>.
qxo commented on pull request #5218:
URL: https://github.com/apache/skywalking/pull/5218#issuecomment-667513354
> Your concern has been removed. Config is totally isolated. Check the master and 8.1 tag. They have landed.
ok, nerver mind.
I'm on the master, which API for external plugin to get/store config ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5218: add a commons config API for get config key/value by: Config.getProperty
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5218:
URL: https://github.com/apache/skywalking/pull/5218#issuecomment-669126247
Yes, I will update the plugin dev doc later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5218: add a commons config API for get config key/value by: Config.getProperty
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5218:
URL: https://github.com/apache/skywalking/pull/5218#issuecomment-667512301
Your concern has been removed. Config is totally isolated. Check the master and 8.1 tag. They have landed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5218: add a commons config API for get config key/value by: Config.getProperty
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5218:
URL: https://github.com/apache/skywalking/pull/5218#issuecomment-667514162
Don't need that API. All config class could be auto injected. Have you noticed all configs in file are same, but no attributes in the core config class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org