You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/08/11 00:41:25 UTC

Review Request 61583: Bundled gRPC v1.4.2 into 3rdparty libraries.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61583/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-7808
    https://issues.apache.org/jira/browse/MESOS-7808


Repository: mesos


Description
-------

The bundled package is generated with the following command:

git clone -b v1.4.2 https://github.com/grpc/grpc.git grpc-1.4.2
(cd grpc-1.4.2 && git submodule update --init third_party/cares)
tar zcvf grpc-1.4.2.tar.gz --exclude .git grpc-1.4.2

We download gRPC from GitHub instead of using the official tarball
because we need to use `git submodule` to download dependent third-party
packages for gRPC, and the necessary git metadata does not exist in the
official tarball.

gRPC also depends on openssl and protobuf 3. Since we have already
bundled the latter, the only system dependency is openssl.


Diffs
-----

  3rdparty/grpc-1.4.2.tar.gz PRE-CREATION 


Diff: https://reviews.apache.org/r/61583/diff/1/


Testing
-------


Thanks,

Chun-Hung Hsiao