You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by aa...@apache.org on 2022/08/03 19:57:13 UTC
[superset] branch arash.afghahi/sc-54452/sql-lab-back-button-on-save-overwrite-modal created (now c1ac657706)
This is an automated email from the ASF dual-hosted git repository.
aafghahi pushed a change to branch arash.afghahi/sc-54452/sql-lab-back-button-on-save-overwrite-modal
in repository https://gitbox.apache.org/repos/asf/superset.git
at c1ac657706 back button fix
This branch includes the following new commits:
new c1ac657706 back button fix
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: back button fix
Posted by aa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aafghahi pushed a commit to branch arash.afghahi/sc-54452/sql-lab-back-button-on-save-overwrite-modal
in repository https://gitbox.apache.org/repos/asf/superset.git
commit c1ac65770640f79f725947a1949ced20e856b5eb
Author: AAfghahi <ar...@gmail.com>
AuthorDate: Wed Aug 3 15:56:55 2022 -0400
back button fix
---
superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx b/superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx
index 12922ef79d..6d6acf8af9 100644
--- a/superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx
+++ b/superset-frontend/src/SqlLab/components/SaveDatasetModal/index.tsx
@@ -357,7 +357,9 @@ export const SaveDatasetModal: FunctionComponent<SaveDatasetModalProps> = ({
)}
{newOrOverwrite === DatasetRadioState.OVERWRITE_DATASET && (
<>
- <Button onClick={handleOverwriteCancel}>Back</Button>
+ {shouldOverwriteDataset && (
+ <Button onClick={handleOverwriteCancel}>Back</Button>
+ )}
<Button
className="md"
buttonStyle="primary"