You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "Tsz-wo Sze (Jira)" <ji...@apache.org> on 2025/01/08 17:18:00 UTC
[jira] [Resolved] (RATIS-2236) Fixed bug where manual triggerSnapshot would never finish
[ https://issues.apache.org/jira/browse/RATIS-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz-wo Sze resolved RATIS-2236.
-------------------------------
Fix Version/s: 3.2.0
Resolution: Fixed
The pull request is now merge. Thanks, [~tanxinyu]!
> Fixed bug where manual triggerSnapshot would never finish
> ---------------------------------------------------------
>
> Key: RATIS-2236
> URL: https://issues.apache.org/jira/browse/RATIS-2236
> Project: Ratis
> Issue Type: Improvement
> Reporter: Xinyu Tan
> Assignee: Xinyu Tan
> Priority: Major
> Fix For: 3.2.0
>
> Attachments: image-2025-01-07-19-20-29-805.png, image-2025-01-07-19-20-48-233.png, image-2025-01-07-19-21-02-451.png
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, there may be some IT failures on IoTDB's CI. By taking a jstack dump, it was found that the issue was caused by a deadlock triggered by the Ratis snapshot.
> !image-2025-01-07-19-21-02-451.png!
> Further investigation of the jstack and the source code of stateMachineUpdater revealed that if the stateMachineUpdater is in the waitForCommit function and there are no new writes, manually triggering a snapshot at this time will cause it to never return. This is because the stateMachineUpdater will remain forever in the waitForCommit function.
> !image-2025-01-07-19-20-48-233.png!
> !image-2025-01-07-19-20-29-805.png!
> The solution is to add an existence check for snapshot requests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)