[GitHub] [airflow] uranusjr commented on a diff in pull request #33266: Refactor: Simplify code in serialization

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #33266:
URL: https://github.com/apache/airflow/pull/33266#discussion_r1289607767


##########
airflow/serialization/helpers.py:
##########
@@ -32,9 +32,10 @@ def serialize_template_field(template_field: Any) -> str | dict | list | int | f
     def is_jsonable(x):
         try:
             json.dumps(x)
-            return True
         except (TypeError, OverflowError):
             return False
+        else:

Review Comment:
   Even the else is arguably not needed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org