You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/05/22 07:14:55 UTC
Review Request 59435: Different developers use different log
directories in
the Ranger Admin installation script. Its processing logic is chaotic. We
should optimize this logic.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59435/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1599
https://issues.apache.org/jira/browse/RANGER-1599
Repository: ranger
Description
-------
Different developers use different log directories in the Ranger Admin installation script. Its processing logic is chaotic. In fact, this log file does not need to be created separately. When the echo "${prefix} $@" >> $LOGFILE command is used, the log file will be created automatically if it does not exist.
We should optimize this logic.
Diffs
-----
security-admin/scripts/setup.sh 3b259a02
Diff: https://reviews.apache.org/r/59435/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 59435: Different developers use different log
directories
in the Ranger Admin installation script. Its processing logic is chaotic.
We should optimize this logic.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59435/#review175606
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 五月 22, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59435/
> -----------------------------------------------------------
>
> (Updated 五月 22, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1599
> https://issues.apache.org/jira/browse/RANGER-1599
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Different developers use different log directories in the Ranger Admin installation script. Its processing logic is chaotic. In fact, this log file does not need to be created separately. When the echo "${prefix} $@" >> $LOGFILE command is used, the log file will be created automatically if it does not exist.
>
> We should optimize this logic.
>
>
> Diffs
> -----
>
> security-admin/scripts/setup.sh 3b259a02
>
>
> Diff: https://reviews.apache.org/r/59435/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 59435: Different developers use different log
directories
in the Ranger Admin installation script. Its processing logic is chaotic.
We should optimize this logic.
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59435/#review175620
-----------------------------------------------------------
Ship it!
Ship It!
- Colm O hEigeartaigh
On May 22, 2017, 7:14 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59435/
> -----------------------------------------------------------
>
> (Updated May 22, 2017, 7:14 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1599
> https://issues.apache.org/jira/browse/RANGER-1599
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Different developers use different log directories in the Ranger Admin installation script. Its processing logic is chaotic. In fact, this log file does not need to be created separately. When the echo "${prefix} $@" >> $LOGFILE command is used, the log file will be created automatically if it does not exist.
>
> We should optimize this logic.
>
>
> Diffs
> -----
>
> security-admin/scripts/setup.sh 3b259a02
>
>
> Diff: https://reviews.apache.org/r/59435/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>