[GitHub] incubator-trafficcontrol pull request #240: [TC-99] api/{version}/cdns/:cdn_...

[amiryesh <gi...@git.apache.org>]

Github user amiryesh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/240#discussion_r98848532
  
    --- Diff: traffic_ops/app/lib/MojoPlugins/Health.pm ---
    @@ -159,6 +159,9 @@ sub register {
     				cachegroups  => [],
     			};
     
    +			$self->app->log->debug("get_cache_health() - " . 
    --- End diff --
    
    I think that a good practice would be to leave debug messages in the code, and set the default log level, at least in production, to "info", so that debug messages will not clutter production logs.
    
    Since the current log level (defined in log4perl.conf) is "debug" (in all environments) I'd suggest to to change this message's log level from "debug" to "trace". 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---